Stop initializing the logger twice in dogstatsd #31662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgimalac
added
changelog/no-changelog
team/agent-shared-components
team/agent-metrics-logs
qa/done
github-actions
bot
added
the
short review
vickenty
approved these changes
Dec 2, 2024
|
/merge |
Devflow running:
|
dd-mergequeue
bot
deleted the
pgimalac/dogstatsd-fix-double-logger-setup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop initializing the logger explicitly in dogstatsd, as it is already initialized when importing the component.
Motivation
The exact same logic is already in
comp/core/logand runs when initializing the log component.There is no need to do the setup again.
Describe how you validated your changes
Ran dogstatsd and checked that it was still able to log as expected.
Possible Drawbacks / Trade-offs
Additional Notes