-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] Fix cgroup dentry resolution for RHEL 7 #31666
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50253337 --os-family=ubuntu Note: This applies to commit bf3aa30 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: def8858 Optimization Goals: ❌ Significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_idle_all_features | memory utilization | +1.28 | [+1.15, +1.41] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_logs | % cpu utilization | +1.22 | [-1.75, +4.19] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.92 | [+0.19, +1.66] | 1 | Logs |
➖ | file_tree | memory utilization | +0.37 | [+0.22, +0.52] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.09 | [-0.54, +0.72] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.01 | [-0.45, +0.47] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.10, +0.11] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.73, +0.70] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.06 | [-0.85, +0.72] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.20 | [-0.99, +0.58] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.27 | [-0.95, +0.40] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.36 | [-0.41, -0.32] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.37 | [-1.14, +0.39] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -1.07 | [-1.13, -1.01] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -1.50 | [-5.00, +2.00] | 1 | Logs |
✅ | basic_py_check | % cpu utilization | -11.18 | [-14.90, -7.47] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_0ms_latency | lost_bytes | 8/10 | |
❌ | file_to_blackhole_300ms_latency | lost_bytes | 9/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
03e0026
to
dffc829
Compare
dffc829
to
bf3aa30
Compare
/merge |
Devflow running:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.61.x 7.61.x
# Navigate to the new working tree
cd .worktrees/backport-7.61.x
# Create a new branch
git switch --create backport-31666-to-7.61.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d667639fb43d0e417ad9207bfbd9de78af52022e
# Push it to GitHub
git push --set-upstream origin backport-31666-to-7.61.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.61.x Then, create a pull request where the |
(cherry picked from commit d667639)
What does this PR do?
Fix the cgroup path resolution on RHEL 7 based kernels.
Motivation
When using cgroup v1, we were taking the base path of the path
but
cgroup.procs
was already stripped from the file, thus causinga wrong resolution of the cgroup path.
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes