Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/DataDog/watermarkpodautoscaler from 0.5.3-0.20241023200123-ab786c1724cf to 0.9.0-rc.1 #31675

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 2, 2024

Bumps github.com/DataDog/watermarkpodautoscaler from 0.5.3-0.20241023200123-ab786c1724cf to 0.9.0-rc.1.

Release notes

Sourced from github.com/DataDog/watermarkpodautoscaler's releases.

v0.9.0-rc.1

Changelog

  • be2a1eb73e8dbb55b691ad582cda884ab48fc435 Add Prometheus metrics verification to reconciler test (#195)
  • 58a5d81dc15158bf4ca5fa6ab126a09631351b7b Add pr linter workflow (#189)
  • 373146b6c7165eaf87963b22e12a8733f8ebad23 Add the possibility to configure the api-server client timeout (#164)
  • e0ae298bd214b44e35ad2bb83530a483272d8b5b Add watermarkpodautoscaler service file (#232)
  • 12cf371b99b51713a8d0492a88a370fcf524c2dc Bump golang.org/x/net from 0.17.0 to 0.23.0 (#208)
  • 3cccc147f9b09226596f95d6ef1559d94b3bbc06 Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 (#205)
  • 0ab50e62799687b7746fa622ff8bea5dfec03bbf Configure Github workflow and job level permissions (#231)
  • fe945b38599280a969a61f38c01cc7f8a1f8faa7 Fix operator deps not existing + panic on nil map + panic not printed to stdout (#228)
  • ab786c1724cfbda1d070f3f7460ca87afda754af Fix the generation of OpenAPI (#226)
  • 23fea1dbc927cad3541c5278867c0db2275c6ab2 Fix yq command in patch-chart.sh (#209)
  • 9adcbcf5a9df4bb6b4370820dead417afa7c6932 Make generating NotScale events configurable; use logs when disabled (#204)
  • dbe256f3fa97c41857cbbfb3155abf9119df2aeb Migrate to kubebuilder multigroup support (#207)
  • 0fe8f73ab5ae2c6f115c6752fdb620a830205f25 Setup nightly build (#233)
  • 1cd7f85e0514156fea9ad4566609c1669a755474 Update CODEOWNERS (#213)
  • ee5c8ef08facaa80dfd02efd448e24ff10e150d5 Update Makefile to better support platform (#206)
  • 02ebc32ba5e2eaa8600c77f154c915efd0652176 Update WPA controller unit-tests to check new upscale-downscale metrics (#218)
  • fe977a9e1feba8c93277aaba6ed790b320b3fe1f Update the chart (#229)
  • 55072eded88b3d1a4b2f77c3c5f825eda30e94c0 [CONTINT-4412] Upgrade k8s dependencies (#221)
  • 0ea2b7f57be695da078aca64ccdc06c5b7b1d322 add merge queue config (#214)
  • 2bdae56cfdf6b3410aa63696cfde1eb9a99572c5 checking if LC annotation is empty to avoid spammy log (#203)
  • 3a21de22c10972f31a84e2a9016f17c19e7b2940 fallback to static token for now (#239)
  • 6e6ed2fec0fcf30bdb3b51029c06c1b15f9acfd9 fix app-id in github actions (#238)
  • f01cf6e2c16b55f7f8355cdccca5ba5495012925 fix(ci): migrate to registry.ddbuild.io for ci images (#212)
  • d4a972bcf98de43f87e2bb7eccf6da5873a0fef7 fix(ci): use new goreleaser parameter (#211)
  • 642a80ca35903e39ef7d8d50839b6795054ce5d6 fix: add missing metrics registration (#215)
  • 496117d346f357beb0283f59a91b153209136a27 fix: github token in github actions (#236)
  • 02e109b8a88f3a09be5bdd7b95e5dcbf83531675 fix: remove temporary gitlab cache to fix ci build (#235)
  • 6eb9bda2543d02121d6b593a2280792d639d490e metrics: add count for number of upscale and downscale (#210)
  • 7d7e7782eea26023d67050006617764b49688d77 recommender: Initial support for third-party replica recommenders (#223)
  • cf7a73277e287947b64204a59e04fe6d35d71d83 recommender: add metrics for recommender http actions (#227)
  • 3d4f9698d6bfa1864dd31d910b1116c3979fa1a1 recommender: fix instrumentation and add tests (#230)
  • 7ae77bfc29b0c9c9295874abcdded718172b1c3a recommender: initial support of HTTP+JSON recommenders (#225)
  • aa6bf7e72d102bc67adac6a1b413d0457e1749b1 reintroduce gitlabci cache (#237)
  • 4d355359d72271f74e5f3ce8129740fb99c6a79e release v0.9.0-rc.1
  • 272d0da231880f1ab35a2b51fda35affa3c606b8 tool: add a script to centralize golang version update (#219)

v0.8.0-rc.2

Changelog

  • be2a1eb Add Prometheus metrics verification to reconciler test (#195)
  • 58a5d81 Add pr linter workflow (#189)
  • 373146b Add the possibility to configure the api-server client timeout (#164)
  • 12cf371 Bump golang.org/x/net from 0.17.0 to 0.23.0 (#208)
  • 3cccc14 Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 (#205)
  • 23fea1d Fix yq command in patch-chart.sh (#209)
  • 9adcbcf Make generating NotScale events configurable; use logs when disabled (#204)
  • 1cd7f85 Update CODEOWNERS (#213)
  • ee5c8ef Update Makefile to better support platform (#206)
  • 0ea2b7f add merge queue config (#214)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/DataDog/watermarkpodautoscaler](https://github.com/DataDog/watermarkpodautoscaler) from 0.5.3-0.20241023200123-ab786c1724cf to 0.9.0-rc.1.
- [Release notes](https://github.com/DataDog/watermarkpodautoscaler/releases)
- [Changelog](https://github.com/DataDog/watermarkpodautoscaler/blob/main/.goreleaser-for-linux.yaml)
- [Commits](https://github.com/DataDog/watermarkpodautoscaler/commits/v0.9.0-rc.1)

---
updated-dependencies:
- dependency-name: github.com/DataDog/watermarkpodautoscaler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Dec 2, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 2, 2024
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9fae2428-02dd-4685-b243-88033d54552e

Baseline: be4b703
Comparison: 141695d
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization -5.40 [-9.23, -1.58] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.02 [-0.92, +4.96] 1 Logs
quality_gate_idle_all_features memory utilization +1.91 [+1.77, +2.04] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.34 [-0.39, +1.08] 1 Logs
file_tree memory utilization +0.12 [-0.04, +0.27] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.05 [-0.01, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.80, +0.86] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.62] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.75, +0.68] 1 Logs
otel_to_otel_logs ingress throughput -0.07 [-0.76, +0.62] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.87, +0.69] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.12 [-0.90, +0.67] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.27 [-0.73, +0.19] 1 Logs
quality_gate_idle memory utilization -0.52 [-0.59, -0.45] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization -1.67 [-5.12, +1.79] 1 Logs
basic_py_check % cpu utilization -5.40 [-9.23, -1.58] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
quality_gate_logs memory_usage 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency short review PR is simple enough to be reviewed quickly team/triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants