[DRAFT] Ndmii 3190 ha agent e2e keep #31682

AlexandreYang · 2024-12-02T21:29:33Z

No description provided.

This reverts commit 849b7ea.

This reverts commit 06e1b58.

agent-platform-auto-pr · 2024-12-02T21:42:26Z

Gitlab CI Configuration Changes

Added Jobs

.on_ha_agent_or_e2e_changes

.on_ha_agent_or_e2e_changes:
- if: $RUN_E2E_TESTS == "off"
  when: never
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
  when: never
- if: $RUN_E2E_TESTS == "on"
  when: on_success
- if: $CI_COMMIT_BRANCH == "main"
  when: on_success
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
  when: on_success
- if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
  when: on_success
- changes:
    compare_to: main
    paths:
    - .gitlab/e2e/e2e.yml
    - test/new-e2e/pkg/**/*
    - test/new-e2e/go.mod
    - flakes.yaml
- changes:
    compare_to: main
    paths:
    - comp/netflow/**/*
    - test/new-e2e/tests/ha-agent/**/*
    - test/new-e2e/go.mod
  when: on_success

new-e2e-ha-agent

new-e2e-ha-agent:
  after_script:
  - $CI_PROJECT_DIR/tools/ci/junit_upload.sh
  artifacts:
    expire_in: 2 weeks
    paths:
    - $E2E_OUTPUT_DIR
    - junit-*.tgz
    reports:
      annotations:
      - $EXTERNAL_LINKS_PATH
    when: always
  before_script:
  - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod/cache
  - rm -f modcache_e2e.tar.xz
  - mkdir -p ~/.aws
  - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config
    || exit $?
  - export AWS_PROFILE=agent-qa-ci
  - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_PUBLIC_KEY_PATH
    || exit $?
  - touch $E2E_PRIVATE_KEY_PATH && chmod 600 $E2E_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
    $AGENT_QA_E2E ssh_key_rsa > $E2E_PRIVATE_KEY_PATH || exit $?
  - pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
  - ARM_CLIENT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE client_id)
    || exit $?; export ARM_CLIENT_ID
  - ARM_CLIENT_SECRET=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE token)
    || exit $?; export ARM_CLIENT_SECRET
  - ARM_TENANT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE tenant_id)
    || exit $?; export ARM_TENANT_ID
  - ARM_SUBSCRIPTION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE subscription_id)
    || exit $?; export ARM_SUBSCRIPTION_ID
  - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_json > ~/gcp-credentials.json
    || exit $?
  - export GOOGLE_APPLICATION_CREDENTIALS=~/gcp-credentials.json
  - inv -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
  image: registry.ddbuild.io/ci/test-infra-definitions/runner$TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX:$TEST_INFRA_DEFINITIONS_BUILDIMAGES
  needs:
  - go_e2e_deps
  - qa_agent
  rules:
  - if: $RUN_E2E_TESTS == "off"
    when: never
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - if: $RUN_E2E_TESTS == "on"
    when: on_success
  - if: $CI_COMMIT_BRANCH == "main"
    when: on_success
  - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
    when: on_success
  - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
    when: on_success
  - changes:
      compare_to: main
      paths:
      - .gitlab/e2e/e2e.yml
      - test/new-e2e/pkg/**/*
      - test/new-e2e/go.mod
      - flakes.yaml
  - changes:
      compare_to: main
      paths:
      - comp/netflow/**/*
      - test/new-e2e/tests/ndm/netflow/**/*
      - test/new-e2e/go.mod
    when: on_success
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - allow_failure: true
    when: manual
  script:
  - inv -e new-e2e-tests.run --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com
    -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password)
    --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer
  stage: e2e
  tags:
  - arch:amd64
  variables:
    E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
    E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
    E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
    E2E_PIPELINE_ID: $CI_PIPELINE_ID
    E2E_PRIVATE_KEY_PATH: /tmp/agent-qa-ssh-key
    E2E_PUBLIC_KEY_PATH: /tmp/agent-qa-ssh-key.pub
    EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
    KUBERNETES_CPU_REQUEST: 6
    KUBERNETES_MEMORY_LIMIT: 16Gi
    KUBERNETES_MEMORY_REQUEST: 12Gi
    SHOULD_RUN_IN_FLAKES_FINDER: 'true'
    TARGETS: ./tests/ha-agent
    TEAM: ndm-core

Changes Summary

Removed	Modified	Added	Renamed
0	0	2	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2024-12-02T21:58:43Z

[Fast Unit Tests Report]

On pipeline 50235985 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

agent-platform-auto-pr · 2024-12-02T22:09:29Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50235985 --os-family=ubuntu

Note: This applies to commit 6d615c5

cit-pr-commenter · 2024-12-02T22:29:06Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 70f9c422-6df1-4ac3-859b-e64712bfcf1d

Baseline: 0e9db52
Comparison: 6d615c5
Diff

Optimization Goals: ❌ Significant changes detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	basic_py_check	% cpu utilization	+7.22	[+3.01, +11.43]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	basic_py_check	% cpu utilization	+7.22	[+3.01, +11.43]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+2.46	[+2.32, +2.59]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.49	[+0.44, +0.54]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.01	[-0.62, +0.63]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.72, +0.73]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.02]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.10, +0.10]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.01	[-0.47, +0.45]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.84, +0.81]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.81, +0.73]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.29	[-1.07, +0.50]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.81	[-1.55, -0.08]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.13	[-4.12, +1.86]	1	Logs
➖	quality_gate_idle	memory utilization	-1.31	[-1.38, -1.24]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-1.43	[-1.57, -1.29]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-1.67	[-2.34, -1.01]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-4.94	[-8.57, -1.31]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	quality_gate_idle	memory_usage	8/10	bounds checks dashboard
❌	quality_gate_idle_all_features	memory_usage	9/10	bounds checks dashboard
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
quality_gate_idle, bounds check memory_usage: 8/10 replicas passed. Failed 2 which is > 0. Gate FAILED.

AlexandreYang added 21 commits November 29, 2024 14:48

draft

15e2bf9

code owner

ba158d9

add ha_agent config

1343d93

test group

8289c28

clean up

06e1b58

print metrics

849b7ea

Revert "print metrics"

5bc67a0

This reverts commit 849b7ea.

Revert "clean up"

7a1c029

This reverts commit 06e1b58.

clean up

69553f3

refactor

7ca10c4

host

4fd5c48

use environments.Host

cb3e127

rename

f06066a

rename

d7a7e5d

rename

5a95d59

draft

5a58fb8

revert test/new-e2e/examples/customenv_with_two_vm_test.go

c48c368

add TestHaAgentAddedToRCListeners

28f95fc

update time

090bf02

update eventually

cb8f19b

update config

5c0c09b

github-actions bot added short review PR is simple enough to be reviewed quickly team/ndm-core labels Dec 2, 2024

update gitlab

6d615c5

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 2, 2024

AlexandreYang closed this Dec 3, 2024

AlexandreYang deleted the NDMII-3190-ha-agent-e2e-keep branch December 3, 2024 08:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRAFT] Ndmii 3190 ha agent e2e keep #31682

[DRAFT] Ndmii 3190 ha agent e2e keep #31682

AlexandreYang commented Dec 2, 2024

agent-platform-auto-pr bot commented Dec 2, 2024

agent-platform-auto-pr bot commented Dec 2, 2024

agent-platform-auto-pr bot commented Dec 2, 2024

cit-pr-commenter bot commented Dec 2, 2024

Fine details of change detection per experiment

Explanation

[DRAFT] Ndmii 3190 ha agent e2e keep #31682

[DRAFT] Ndmii 3190 ha agent e2e keep #31682

Conversation

AlexandreYang commented Dec 2, 2024

agent-platform-auto-pr bot commented Dec 2, 2024

Gitlab CI Configuration Changes

Added Jobs

Changes Summary

agent-platform-auto-pr bot commented Dec 2, 2024

agent-platform-auto-pr bot commented Dec 2, 2024

Test changes on VM

cit-pr-commenter bot commented Dec 2, 2024

Regression Detector

Regression Detector Results

Optimization Goals: ❌ Significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision