Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Aurora instances per cluster #31846

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Query Aurora instances per cluster #31846

merged 3 commits into from
Dec 6, 2024

Conversation

sethsamuel
Copy link
Contributor

What does this PR do?

Updates Aurora autodiscovery to query database instances per cluster.

Motivation

DescribeDBInstances has a limit of 100 instances per call. As a first pass at handling large AWS RDS installations this will allow the agent to autodiscover up to 100 instances per cluster, rather than 100 instances total.

Describe how you validated your changes

Mocked tests have been updated but full confirmation can only be done in a deployment to a customer with a large number of Aurora instances being autodiscovered.

Possible Drawbacks / Trade-offs

Additional Notes

@sethsamuel sethsamuel requested a review from a team as a code owner December 6, 2024 17:45
@github-actions github-actions bot added team/database-monitoring short review PR is simple enough to be reviewed quickly labels Dec 6, 2024
@sethsamuel sethsamuel added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Dec 6, 2024
@sethsamuel sethsamuel requested a review from a team as a code owner December 6, 2024 17:51
@sethsamuel sethsamuel added the backport/7.61.x Automatically create a backport PR to 7.61.x label Dec 6, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50475185 --os-family=ubuntu

Note: This applies to commit 23062ae

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50475185 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@sethsamuel
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 6, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-06 18:58:42 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-06 20:01:43 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@sethsamuel
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Dec 6, 2024

Devflow running: /remove

View all feedbacks in Devflow UI.

2024-12-06 20:01:43 UTC ℹ️ Devflow: /remove

@sethsamuel
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 6, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-06 20:02:10 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit d255f0c into main Dec 6, 2024
229 checks passed
@dd-mergequeue dd-mergequeue bot deleted the seth.samuel/DBMON-4771-Fix-pagination-for-Aurora-cluster-DBs-100-records branch December 6, 2024 20:25
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 6, 2024
agent-platform-auto-pr bot pushed a commit that referenced this pull request Dec 6, 2024
@sethsamuel @github-actions
Query Aurora instances per cluster (#31846)
675c35e 
(cherry picked from commit d255f0c)
@agent-platform-auto-pr agent-platform-auto-pr bot mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zhengda lu-zhengda lu-zhengda approved these changes

@cswatt cswatt cswatt approved these changes

Assignees
No one assigned
Labels
backport/7.61.x Automatically create a backport PR to 7.61.x qa/rc-required Only for a PR that requires validation on the Release Candidate short review PR is simple enough to be reviewed quickly team/database-monitoring
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sethsamuel @cswatt @lu-zhengda