Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apm_config.additional_endpoints to authorized config paths #31851

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

liustanley
Copy link
Contributor

What does this PR do?

Adds apm_config.additional_endpoints to the set of authorized config paths.

Motivation

As part of #incident-33011 we noticed that configsync in the otel agent wasn't updating the API key from apm_config.additional_endpoints. This change fixes this issue and the otel agent is able to fetch the additional endpoints API key from the core agent to send traces.

Describe how you validated your changes

Validated locally

Possible Drawbacks / Trade-offs

Additional Notes

@liustanley liustanley added the backport/7.61.x Automatically create a backport PR to 7.61.x label Dec 6, 2024
@liustanley liustanley added this to the 7.61.0 milestone Dec 6, 2024
@liustanley liustanley requested a review from a team as a code owner December 6, 2024 19:57
@liustanley liustanley requested a review from ogaca-dd December 6, 2024 19:57
@github-actions github-actions bot added team/agent-shared-components short review PR is simple enough to be reviewed quickly labels Dec 6, 2024
@liustanley liustanley added changelog/no-changelog qa/rc-required Only for a PR that requires validation on the Release Candidate qa/done QA done before merge and regressions are covered by tests and removed qa/rc-required Only for a PR that requires validation on the Release Candidate labels Dec 6, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50481671 --os-family=ubuntu

Note: This applies to commit 50e1064

@liustanley
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 6, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-06 20:50:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-06 20:54:16 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 23m.

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4f7a79a1-0b2f-4e72-ae08-b418bc9338cd

Baseline: 858cb1c
Comparison: 50e1064
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.26 [-1.71, +4.23] 1 Logs
quality_gate_idle_all_features memory utilization +0.95 [+0.83, +1.07] 1 Logs bounds checks dashboard
file_tree memory utilization +0.27 [+0.13, +0.40] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.17 [-0.60, +0.94] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.14 [-0.32, +0.60] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.08 [-0.64, +0.80] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.91, +0.96] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.11, +0.10] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.78, +0.75] 1 Logs
quality_gate_idle memory utilization -0.30 [-0.34, -0.26] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -0.31 [-1.00, +0.39] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.47 [-0.53, -0.41] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.80 [-1.52, -0.08] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 8/10
file_to_blackhole_100ms_latency lost_bytes 8/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit 07187c1 into main Dec 6, 2024
262 of 266 checks passed
@dd-mergequeue dd-mergequeue bot deleted the stanley.liu/add-apm-config branch December 6, 2024 21:16
@github-actions github-actions bot modified the milestones: 7.61.0, 7.62.0 Dec 6, 2024
agent-platform-auto-pr bot pushed a commit that referenced this pull request Dec 6, 2024
@liustanley liustanley added the backport/7.60.x Automatically create a backport PR to 7.60.x label Dec 10, 2024
agent-platform-auto-pr bot pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.60.x Automatically create a backport PR to 7.60.x backport/7.61.x Automatically create a backport PR to 7.61.x changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants