[CWS] Move tags from cgroup to tags resolver #31874
Conversation
lebauce
added
changelog/no-changelog
team/agent-security
qa/done
github-actions
bot
added
component/system-probe
medium review
lebauce
force-pushed
the
lebauce/decouple-cgroup-and-tags
branch
4 times, most recently
from
c589d3c to
5c775d2
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50709439 --os-family=ubuntuNote: This applies to commit 1b09931 |
lebauce
force-pushed
the
lebauce/decouple-cgroup-and-tags
branch
from
5c775d2 to
c74cb76
Compare
Package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 7c1a13b Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +2.02 | [-0.98, +5.03] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.75 | [+1.03, +2.47] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.15 | [-0.31, +0.60] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.14 | [-0.62, +0.91] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.14 | [-0.49, +0.78] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.05 | [-0.85, +0.95] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.71, +0.79] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.03 | [-0.09, +0.16] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.02 | [-0.83, +0.88] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.12, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.09 | [-0.77, +0.59] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.24 | [-0.89, +0.41] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.42 | [-1.22, +0.38] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.67 | [-0.79, -0.56] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.74 | [-0.78, -0.70] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.34 | [-1.40, -1.28] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 5/10 | |
| ❌ | file_to_blackhole_300ms_latency | lost_bytes | 9/10 | |
| ❌ | file_to_blackhole_500ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
|
||
| // Copy returns a copy of the selector | ||
| func (ws WorkloadSelector) Copy() *WorkloadSelector { | ||
| return &WorkloadSelector{ |
There was a problem hiding this comment.
ws is already a copy here since the receiver is not a pointer. Maybe you could return &ws directly ?
I'm not a fan of this kind of copy method where it's super easy to forget new fields
|
/merge |
Devflow running:
|
What does this PR do?
Extract tags from cgroup resolver and move it to tags resolver.
Motivation
This allows not having to deal with low level object (
cgroup.CacheEntry) in activity dump and security profile managers.Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes