Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected how we submit the oracle.can_connect check #31945

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aldrickdev
Copy link

@aldrickdev aldrickdev commented Dec 9, 2024

What does this PR do?

This PR will correct how we submit the oracle.can_connect so that the expected host tag is added.

Motivation

SDBM-1373

Describe how you validated your changes

The changes can be validated by making sure that the value for the host tag on the oracle.can_connect has the value of the database instance.

Possible Drawbacks / Trade-offs

Additional Notes

@aldrickdev aldrickdev requested a review from a team as a code owner December 9, 2024 22:57
@bits-bot
Copy link
Collaborator

bits-bot commented Dec 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added team/database-monitoring short review PR is simple enough to be reviewed quickly labels Dec 9, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 9, 2024

Package size comparison

Comparison with ancestor 4f0073dbe2585abdc01c50d1188c3609c6bcf3f9

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb -0.02MB 1270.94MB 1270.96MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.20MB 113.20MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ⚠️ 526.45MB 526.44MB 70.00MB
datadog-agent-x86_64-rpm -0.02MB 1280.18MB 1280.19MB 140.00MB
datadog-agent-x86_64-suse -0.02MB 1280.18MB 1280.19MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.26MB 113.26MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.26MB 113.26MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb 0.01MB ⚠️ 1005.13MB 1005.12MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.67MB 108.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 1014.34MB 1014.34MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.74MB 108.74MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 9, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50979184 --os-family=ubuntu

Note: This applies to commit 145501d

@nenadnoveljic
Copy link
Contributor

nenadnoveljic commented Dec 10, 2024

Can you add a test case and an entry in the change log?

Copy link

cit-pr-commenter bot commented Dec 11, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b4c348fb-6197-42d7-9fb5-62c9d3bac9cb

Baseline: 4f0073d
Comparison: 145501d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.57 [+0.51, +0.64] 1 Logs
quality_gate_idle memory utilization +0.36 [+0.32, +0.41] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.12 [-0.34, +0.59] 1 Logs
otel_to_otel_logs ingress throughput +0.09 [-0.63, +0.80] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.81, +0.90] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.79, +0.75] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.88, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.80, +0.75] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.06 [-0.69, +0.57] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.07 [-0.71, +0.56] 1 Logs
file_tree memory utilization -0.32 [-0.44, -0.19] 1 Logs
quality_gate_logs % cpu utilization -0.32 [-3.25, +2.61] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.32 [-1.09, +0.46] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.57 [-1.30, +0.15] 1 Logs
quality_gate_idle_all_features memory utilization -0.58 [-0.71, -0.46] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http1 lost_bytes 9/10
file_to_blackhole_0ms_latency_http2 lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 11, 2024
@nenadnoveljic
Copy link
Contributor

Some labels and release note are missing.

@aldrickdev aldrickdev added qa/done QA done before merge and regressions are covered by tests category/bugfix labels Dec 12, 2024
@aldrickdev aldrickdev requested a review from a team as a code owner December 12, 2024 16:49
@nenadnoveljic
Copy link
Contributor

@aldrickdev Thanks for fixing this! Ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/bugfix medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/database-monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants