Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assign_issue): Add the required slack token #31949

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Dec 10, 2024

What does this PR do?

Add the slack token required to send a message to an internal team

Motivation

Fix the failing workflow

Describe how you validated your changes

Ran the job locally

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested a review from a team as a code owner December 10, 2024 08:08
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 10, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 10, 2024
@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor 5e3a9d7cbe4c2d1f6a1ba917b8d45e1c1448b0a8

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1270.85MB 1270.85MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.20MB 113.20MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 526.45MB 526.45MB 70.00MB
datadog-agent-x86_64-rpm -0.00MB 1280.09MB 1280.09MB 140.00MB
datadog-agent-x86_64-suse -0.00MB 1280.09MB 1280.09MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.26MB 113.26MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.26MB 113.26MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb 0.00MB 1005.03MB 1005.03MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.67MB 108.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB 1014.24MB 1014.24MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.74MB 108.74MB 10.00MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50673892 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2920c59-54ee-46ae-b8fc-929deed8bf7c

Baseline: 5e3a9d7
Comparison: f8c69f0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +1.82 [+1.68, +1.95] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +1.08 [+0.36, +1.81] 1 Logs
otel_to_otel_logs ingress throughput +0.53 [-0.12, +1.19] 1 Logs
file_tree memory utilization +0.36 [+0.24, +0.48] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.09 [+0.04, +0.15] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.73, +0.78] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.80, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.87, +0.88] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.09] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.84, +0.81] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.83, +0.75] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.83, +0.71] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.25 [-0.72, +0.22] 1 Logs
quality_gate_idle memory utilization -0.65 [-0.70, -0.61] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.11 [-4.05, +1.84] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 7/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@chouetz
Copy link
Member Author

chouetz commented Dec 10, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 10, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-10 09:29:57 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit a7ba911 into main Dec 10, 2024
231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/add_token branch December 10, 2024 09:51
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants