Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROCS-4589] Split K8s e2e test #31985

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[PROCS-4589] Split K8s e2e test #31985

merged 2 commits into from
Dec 10, 2024

Conversation

daniel-taf
Copy link
Contributor

@daniel-taf daniel-taf commented Dec 10, 2024 •
edited
Loading

What does this PR do?

Splits off the K8s core agent tests into their own suite.

Motivation

Flakes in the core agent tests due to improper environment (process agent present when it shouldn't be).

Describe how you validated your changes

Validated the split

--- PASS: TestK8sTestSuite (890.74s)
    --- PASS: TestK8sTestSuite/TestManualContainerCheck (16.97s)
    --- PASS: TestK8sTestSuite/TestManualProcessCheck (17.72s)
    --- PASS: TestK8sTestSuite/TestManualProcessDiscoveryCheck (11.76s)
    --- PASS: TestK8sTestSuite/TestProcessCheck (21.34s)
    --- PASS: TestK8sTestSuite/TestProcessDiscoveryCheck (68.18s)
PASS
ok  	github.com/DataDog/datadog-agent/test/new-e2e/tests/process	893.787s

DONE 6 tests in 917.562s
All tests passed

--- PASS: TestK8sCoreAgentTestSuite (946.24s)
    --- PASS: TestK8sCoreAgentTestSuite/TestProcessCheckInCoreAgent (31.48s)
    --- PASS: TestK8sCoreAgentTestSuite/TestProcessCheckInCoreAgentWithNPM (85.65s)
PASS
ok  	github.com/DataDog/datadog-agent/test/new-e2e/tests/process	949.421s

DONE 3 tests in 974.248s
All tests passed

Possible Drawbacks / Trade-offs

Additional Notes

@daniel-taf daniel-taf changed the title [PROCS-4589] Split K8s e2e test [PROCS-4589] Split K8s e2e test into suites by agent Dec 10, 2024
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/processes labels Dec 10, 2024
@daniel-taf daniel-taf added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 10, 2024
@daniel-taf daniel-taf marked this pull request as ready for review December 10, 2024 20:47
@daniel-taf daniel-taf requested a review from a team as a code owner December 10, 2024 20:47
@daniel-taf daniel-taf changed the title [PROCS-4589] Split K8s e2e test into suites by agent [PROCS-4589] Split K8s e2e test Dec 10, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50763954 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor 7d6be816588ecded8a60f2e88936371b199ebfdd

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB ✅ 1271.23MB 1271.23MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 113.18MB 113.18MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 526.41MB 526.41MB 70.00MB
datadog-agent-x86_64-rpm 0.00MB ⚠️ 1280.46MB 1280.46MB 140.00MB
datadog-agent-x86_64-suse 0.00MB ⚠️ 1280.46MB 1280.46MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 113.25MB 113.25MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 113.25MB 113.25MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb 0.00MB ✅ 1005.39MB 1005.39MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 108.65MB 108.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB ⚠️ 1014.61MB 1014.61MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 108.72MB 108.72MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50763954 --os-family=ubuntu

Note: This applies to commit ce9a1b6

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a22ee0ef-2a89-4b44-9c25-5468cf165383

Baseline: 7d6be81
Comparison: ce9a1b6
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_idle_all_features memory utilization +1.17 [+1.06, +1.28] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization +0.88 [-2.04, +3.81] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.64 [-0.08, +1.36] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.39 [-0.39, +1.18] 1 Logs
➖ otel_to_otel_logs ingress throughput +0.32 [-0.36, +0.99] 1 Logs
➖ file_tree memory utilization +0.13 [+0.01, +0.26] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.09 [-0.66, +0.85] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.85, +0.89] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.01 [-0.75, +0.77] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.09] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.84, +0.84] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.00 [-0.46, +0.45] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.01 [-0.87, +0.86] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.62] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.26 [-0.32, -0.19] 1 Logs
➖ quality_gate_idle memory utilization -0.62 [-0.66, -0.57] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ file_to_blackhole_0ms_latency_http1 lost_bytes 9/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@daniel-taf
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 10, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-10 22:10:26 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit 706fa94 into main Dec 10, 2024
229 of 232 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daniel.tafoya/split-k8s-test branch December 10, 2024 22:32
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertjli robertjli robertjli approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/processes
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-taf @robertjli