Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump nikos to 1.12.8 #32005

Merged
merged 1 commit into from
Dec 12, 2024
Merged

bump nikos to 1.12.8 #32005

merged 1 commit into from
Dec 12, 2024
+3 −3

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Dec 11, 2024 •
edited
Loading

What does this PR do?

Bump nikos to v1.12.8 https://github.com/DataDog/nikos/releases/tag/v1.12.8, only sub-dependencies bump.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 11, 2024 •
edited
Loading

Go Package Import Differences

Baseline: 5b2054c
Comparison: b62b4b7

binaryosarchchange
system-probelinuxamd64
+0, -3 
-github.com/shirou/gopsutil/v3/common
-github.com/shirou/gopsutil/v3/host
-github.com/shirou/gopsutil/v3/internal/common
system-probelinuxarm64
+0, -3 
-github.com/shirou/gopsutil/v3/common
-github.com/shirou/gopsutil/v3/host
-github.com/shirou/gopsutil/v3/internal/common

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 11, 2024 •
edited
Loading

Package size comparison

Comparison with ancestor 5b2054cb1da177beebdbbc4eacc59278c7eb92dd

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB ✅ 1265.77MB 1265.77MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 113.25MB 113.25MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 78.42MB 78.42MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 526.60MB 526.60MB 70.00MB
datadog-agent-x86_64-rpm -0.00MB ✅ 1275.00MB 1275.00MB 140.00MB
datadog-agent-x86_64-suse -0.00MB ✅ 1275.00MB 1275.00MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 113.32MB 113.32MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 113.32MB 113.32MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 78.50MB 78.50MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 78.50MB 78.50MB 10.00MB
datadog-agent-arm64-deb 0.00MB ✅ 1000.86MB 1000.86MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 108.73MB 108.73MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 55.65MB 55.65MB 10.00MB
datadog-agent-aarch64-rpm -0.00MB ✅ 1010.08MB 1010.08MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 108.80MB 108.80MB 10.00MB

Decision

✅ Passed

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 11, 2024 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 23ac8d61-5fd6-48db-b0be-1b02807fe912

Baseline: 5b2054c
Comparison: b62b4b7
Diff

❌ Experiments with missing or malformed data

This is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out.

  • otel_to_otel_logs (Logs)

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +1.87 [-1.09, +4.84] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.15 [-0.31, +0.61] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.06 [-0.72, +0.84] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.78, +0.83] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.00 [-0.12, +0.11] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency egress throughput -0.01 [-0.77, +0.76] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.10, +0.09] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.80, +0.78] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.02 [-0.79, +0.75] 1 Logs
➖ quality_gate_idle memory utilization -0.20 [-0.25, -0.16] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency egress throughput -0.28 [-1.06, +0.50] 1 Logs
➖ file_tree memory utilization -0.36 [-0.48, -0.24] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.66 [-0.72, -0.59] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -1.10 [-1.83, -0.37] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux paulcacheux force-pushed the paulcacheux/bump-nikos-1.12.8 branch from f402cc4 to b62b4b7 Compare December 12, 2024 16:39
@paulcacheux paulcacheux added team/agent-security qa/done QA done before merge and regressions are covered by tests changelog/no-changelog and removed team/agent-shared-components labels Dec 12, 2024
@github-actions github-actions bot removed the long review PR is complex, plan time to review it label Dec 12, 2024
@paulcacheux paulcacheux marked this pull request as ready for review December 12, 2024 16:41
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 12, 2024
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 12, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-12 16:47:06 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-12 17:45:17 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 27m.

2024-12-12 17:57:50 UTC ℹ️ MergeQueue: Retrying because previous merge request failed

2024-12-12 18:22:08 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit d352e48 into main Dec 12, 2024
258 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/bump-nikos-1.12.8 branch December 12, 2024 18:22
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spikat spikat spikat approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Milestone
7.62.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcacheux @spikat