Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] ignore otel collector package updates in dependabot #32024

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Dec 11, 2024

What does this PR do?

ignore otel collector package updates in dependabot

Motivation

OpenTelemetry collector packages need to be updated with inv rather than dependabot

@songy23 songy23 added changelog/no-changelog team/opentelemetry OpenTelemetry team qa/no-code-change No code change in Agent code requiring validation labels Dec 11, 2024
@songy23 songy23 added this to the 7.62.0 milestone Dec 11, 2024
@songy23 songy23 requested a review from a team as a code owner December 11, 2024 14:44
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 11, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50840266 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor 7bab2dc3c32ab019b7e5a03c4a14d0fb439a69ed

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB ⚠️ 1271.32MB 1271.32MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.22MB 113.22MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.33MB 78.33MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ⚠️ 526.49MB 526.49MB 70.00MB
datadog-agent-x86_64-rpm 0.00MB ⚠️ 1280.56MB 1280.56MB 140.00MB
datadog-agent-x86_64-suse 0.00MB ⚠️ 1280.56MB 1280.56MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.29MB 113.29MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.29MB 113.29MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.41MB 78.41MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.41MB 78.41MB 10.00MB
datadog-agent-arm64-deb 0.00MB ⚠️ 1005.47MB 1005.47MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.71MB 108.71MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.60MB 55.60MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB ⚠️ 1014.68MB 1014.68MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.78MB 108.78MB 10.00MB

Decision

⚠️ Warning

@songy23
Copy link
Member Author

songy23 commented Dec 11, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-11 15:23:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-11 15:40:54 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 25m.


2024-12-11 16:36:44 UTC ℹ️ MergeQueue: This merge request was merged

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a1a3764b-b592-4263-92ad-37dfef5b3dda

Baseline: 7bab2dc
Comparison: ceaae2d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.94 [+0.21, +1.67] 1 Logs
file_tree memory utilization +0.14 [+0.02, +0.25] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.75, +0.81] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.68, +0.73] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.83, +0.82] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.08] 1 Logs
otel_to_otel_logs ingress throughput -0.04 [-0.78, +0.69] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.87, +0.78] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.84, +0.72] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.07 [-0.85, +0.71] 1 Logs
quality_gate_logs % cpu utilization -0.11 [-3.02, +2.79] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.12 [-0.75, +0.51] 1 Logs
quality_gate_idle memory utilization -0.12 [-0.17, -0.08] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.19 [-0.24, -0.13] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.20 [-0.65, +0.26] 1 Logs
quality_gate_idle_all_features memory utilization -2.95 [-3.06, -2.83] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit 49325ca into main Dec 11, 2024
212 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dependabot-otel branch December 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants