Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile metadata to JSON schema #32033

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NouhaManai96
Copy link
Contributor

@NouhaManai96 NouhaManai96 commented Dec 11, 2024

What does this PR do?

Add profile metadata to JSON schema

Motivation

We are adding support for the metadata

Describe how you validated your changes

This structure is used on the backend side by RC, changes were validated by sending requests with the new fields to the rc-api and making sure they succeeded.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/ndm-core short review PR is simple enough to be reviewed quickly labels Dec 11, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 11, 2024

Package size comparison

Comparison with ancestor 6b70b84aebd4b35f9661d0fb3fe97dbe6f90dddf

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1271.61MB 1271.61MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.29MB 113.29MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.41MB 78.41MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 526.65MB 526.65MB 70.00MB
datadog-agent-x86_64-rpm 0.00MB 1280.85MB 1280.85MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1280.85MB 1280.85MB 140.00MB
datadog-iot-agent-x86_64-rpm -0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse -0.00MB 113.35MB 113.35MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.49MB 78.49MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.49MB 78.49MB 10.00MB
datadog-agent-arm64-deb 0.00MB 1005.67MB 1005.67MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.76MB 108.76MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.64MB 55.64MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB 1014.89MB 1014.89MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ⚠️ 108.83MB 108.83MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50856607 --os-family=ubuntu

Note: This applies to commit 73e7b0f

Copy link
Contributor

@dplepage-dd dplepage-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NouhaManai96 NouhaManai96 added the qa/done QA done before merge and regressions are covered by tests label Dec 12, 2024
@NouhaManai96 NouhaManai96 marked this pull request as ready for review December 12, 2024 18:35
@NouhaManai96 NouhaManai96 requested a review from a team as a code owner December 12, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/ndm-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants