-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTEL-2304] export obfuscateStatsGroup function #32064
base: main
Are you sure you want to change the base?
Conversation
pkg/trace/agent/obfuscate.go
Outdated
func (a *Agent) obfuscateStatsGroup(b *pb.ClientGroupedStats) { | ||
o := a.lazyInitObfuscator() | ||
|
||
func obfuscateStatsGroup(o *obfuscate.Obfuscator, b *pb.ClientGroupedStats) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we have other dependencies not in Agent using this function; I could break out this change to a helper function instead of changing the signature
Package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50918637 --os-family=ubuntu Note: This applies to commit 454ae11 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 3c882e7 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_logs | % cpu utilization | +2.67 | [-0.29, +5.63] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.98 | [+0.26, +1.70] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.53 | [+0.49, +0.58] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.27 | [-0.19, +0.73] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.22 | [-0.41, +0.86] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.22 | [-0.56, +1.01] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.21 | [-0.45, +0.87] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.14 | [-0.63, +0.91] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.79, +0.82] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.01 | [-0.78, +0.80] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.81, +0.83] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.08, +0.09] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.10 | [-0.84, +0.65] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.11 | [-0.17, -0.06] | 1 | Logs |
➖ | file_tree | memory utilization | -0.27 | [-0.39, -0.15] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -2.69 | [-2.81, -2.57] | 1 | Logs bounds checks dashboard |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_100ms_latency | lost_bytes | 8/10 | |
❌ | file_to_blackhole_300ms_latency | lost_bytes | 8/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
What does this PR do?
removes
*Agent
type receiver from obfuscateStatsGroup function and exports for use in other Datadog componentsMotivation
enable obfuscation for APM trace metrics for OTel Collector customers inside datadogconnector: open-telemetry/opentelemetry-collector-contrib#35401
We don't want to have to duplicate this function or duplicate instantiating an entire Agent inside datadogconnector component; if this is accepted and merged I can just import this function and pass in the obfuscator we instantiate there.
Describe how you validated your changes
made change to existing unit test
Possible Drawbacks / Trade-offs
need to pass obfuscator pointer to the function instead of just calling on Agent struct pointer; any downstream dependencies that import this function
Additional Notes
If we know that any other datadog or downstream dependencies are using this function currently; I'd be happy to break out a helper function that takes obfuscator as a pointer and keep the existing signature as a shell for compatibility. Let me know if this is the case