Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] send signal event when targeting multiple processes #32108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spikat
Copy link
Contributor

@spikat spikat commented Dec 12, 2024

What does this PR do?

Motivation

Be able to detect signal sent with 0 or -1 as pid kill argument. In this case, target process will not be resolved.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@spikat spikat added changelog/no-changelog team/agent-security qa/done QA done before merge and regressions are covered by tests labels Dec 12, 2024
@spikat spikat added this to the 7.62.0 milestone Dec 12, 2024
@spikat spikat requested a review from a team as a code owner December 12, 2024 16:42
@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly labels Dec 12, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50975761 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor 8ca1369d2b6deeee0c640ce05dfe2c38186b61d5

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb -0.01MB 1271.25MB 1271.25MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.20MB 113.20MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB ⚠️ 526.44MB 526.44MB 70.00MB
datadog-agent-x86_64-rpm -0.01MB 1280.48MB 1280.49MB 140.00MB
datadog-agent-x86_64-suse -0.01MB 1280.48MB 1280.49MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.27MB 113.27MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.27MB 113.27MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb 0.01MB ⚠️ 1005.43MB 1005.42MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.70MB 108.70MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 1014.64MB 1014.64MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.77MB 108.77MB 10.00MB

Decision

⚠️ Warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants