fix(aws): Don't build the cache on cold start #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Boutour <[email protected]>
| @@ -67,29 +63,6 @@ def get(self, log_group_arn): | |||
| def _should_fetch_tags(self): | |||
| return os.environ.get("DD_FETCH_LOG_GROUP_TAGS", "false").lower() == "true" | |||
|
|
|||
| def _build_tags_cache(self): | |||
There was a problem hiding this comment.
nit: you may want to keep this code there and just remove its usage above
There was a problem hiding this comment.
It's not called somewhere else, it will be a dead code. If we want to revert it, it's preferable to revert the commit I think.
RaphaelAllier
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Don't load all the existing caches in memory prior to proceed.
Motivation
Reduce CPU and S3 usage for customer with large number of log groups.
Testing Guidelines
Additional Notes
Types of changes
Check all that apply