found a DC bug in 15.1.0

DataDog · Sep 21, 2023 · 5e1b811 · 5e1b811
1 parent 9ebd9db
commit 5e1b811
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/checks.js b/checks.js
@@ -1,4 +1,7 @@
 const [ MAJOR, MINOR, PATCH ] = process.versions.node.split('.').map(Number);
+module.exports.MAJOR = MAJOR;
+module.exports.MINOR = MINOR;
+module.exports.PATCH = PATCH;
 
 function hasFullSupport() {
   return MAJOR >= 20;

diff --git a/test/test-diagnostics-channel-has-subscribers.spec.js b/test/test-diagnostics-channel-has-subscribers.spec.js
@@ -1,13 +1,22 @@
 'use strict';
 
-require('./common.js');
-
 const assert = require('assert');
 const test = require('tape');
 
 const { channel, hasSubscribers } = require('../dc-polyfill.js');
 
+const { MAJOR, MINOR } = require('../checks.js');
+
 test('test-diagnostics-channel-has-subscribers', t => {
+  if (MAJOR === 15 && MINOR === 1) {
+    // node:diagnostics_channel:110
+    // if (ref) channel = WeakRefPrototypeGet(ref);
+    // TypeError: WeakRefPrototypeGet is not a function
+    t.comment('SKIPPING TEST DUE TO A BUG IN THIS VERSION OF NODE.JS');
+    t.end();
+    return
+  }
+
   const dc = channel('test-diagnostics-channel-has-subscribers');
   t.ok(!hasSubscribers('test-diagnostics-channel-has-subscribers'));