New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: removing a final TODO #5

Merged

tlhunter merged 1 commit into main from tlhunter/remove-final-todo

Oct 20, 2023

Member

tlhunter commented Oct 19, 2023

only a final TODO entry remained
I had presumed this was an issue with mustCall but wanted to confirm


          test: removing a final TODO

2747f36

tlhunter added the test label

tlhunter commented

View reviewed changes

patch-tracing-channel.js

@@ @@ -98,15 +98,15 @@ module.exports = function (unpatched) { @@
                       context.error = err;
                       error.publish(context);
                       asyncStart.publish(context);
-                      // TODO: Is there a way to have asyncEnd _after_ the continuation?

Member Author

tlhunter Oct 19, 2023

Removing the two TODO comments in this file since it's from upstream code and not a TODO of this project. That way we can grep.

tlhunter merged commit 56954af into main

33 checks passed

tlhunter deleted the tlhunter/remove-final-todo branch

October 20, 2023 09:46

tlhunter added the semver-null label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-null test