Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary patching for Node.js v20.0-v20.5 #6

Merged
merged 3 commits into from
Nov 7, 2023
Merged

remove unnecessary patching for Node.js v20.0-v20.5 #6

merged 3 commits into from
Nov 7, 2023

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Nov 6, 2023 •
edited
Loading

  • the definition of hasFullSupport changed from >= v20 to >= v20.6
    • this resulted in the store methods being patched for v20.0 to v20.5
    • same with tracing channel and top subscribe/unsubscribe
  • these versions don't need to be patched so dc-polyfill is doing unnecessary work

@tlhunter tlhunter requested a review from Qard November 6, 2023 20:18
@tlhunter tlhunter changed the title remove superfluous patching of store methods for v20.0-v20.5 remove unnecessary patching for Node.js v20.0-v20.5 Nov 6, 2023
@tlhunter tlhunter merged commit 44e6695 into main Nov 7, 2023
34 checks passed
@tlhunter tlhunter deleted the tlhunter/remove-repatch-store-methods branch November 7, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanayan123 khanayan123 khanayan123 approved these changes

@Qard Qard Awaiting requested review from Qard

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlhunter @khanayan123