Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test native <-> polyfill publish/subscribe #7

Merged
merged 1 commit into from
Nov 21, 2023
Merged

test native <-> polyfill publish/subscribe #7

merged 1 commit into from
Nov 21, 2023

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Nov 21, 2023 •
edited
Loading

  • had a conversation with @astuyve today and realized there weren't tests for this
  • tests that publishing in polyfill can be received by native DC
  • tests that publishing in native DC can be received by polyfill
  • doesn't require a release as this doesn't change the package contents

@tlhunter tlhunter added semver-patch semver-null Doesn't affect semver (e.g. tests, docs, CI) test Change is only related to testing and doesn't deserve a release and removed semver-patch labels Nov 21, 2023
@tlhunter tlhunter merged commit f6086b3 into main Nov 21, 2023
34 checks passed
@tlhunter tlhunter deleted the tlhunter/test-cross-communication branch November 21, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanayan123 khanayan123 khanayan123 approved these changes

Assignees
No one assigned
Labels
semver-null Doesn't affect semver (e.g. tests, docs, CI) test Change is only related to testing and doesn't deserve a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlhunter @khanayan123