RUM-7174 Introduce the setNetworkSettledInitialResourceIdentifier API #2424
+352
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
force-pushed
the
mconstantin/rum-7174/add-timing-strategy-for-ttns-requests-identification
branch
from
8f6c29d
to
dd94ef2
Compare
mariusc83
changed the title
mariusc83
force-pushed
the
mconstantin/rum-7174/add-timing-strategy-for-ttns-requests-identification
branch
from
dd94ef2
to
a151145
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/view-loading-times #2424 +/- ##
==============================================================
+ Coverage 69.96% 70.11% +0.15%
==============================================================
Files 775 775
Lines 28647 28676 +29
Branches 4805 4807 +2
==============================================================
+ Hits 20042 20105 +63
+ Misses 7277 7251 -26
+ Partials 1328 1320 -8
|
xgouchet
approved these changes
Dec 3, 2024
| * a threshold of 100ms. | ||
| * @param initialResourceIdentifier the [InitialResourceIdentifier] to use. | ||
| */ | ||
| fun setNetworkSettledInitialResourceIdentifier(initialResourceIdentifier: InitialResourceIdentifier): Builder { |
There was a problem hiding this comment.
Note
This function's name is a bit long, maybe we can rename it to setInitialResourceIdentifier?
| @@ -127,6 +130,7 @@ internal class RumFeature( | |||
| private var anrDetectorExecutorService: ExecutorService? = null | |||
| internal var anrDetectorRunnable: ANRDetectorRunnable? = null | |||
| internal lateinit var appContext: Context | |||
| internal var networkSettledInitialResourceIdentifier: InitialResourceIdentifier = NoOpInitialResourceIdentifier() | |||
There was a problem hiding this comment.
Note
Same, maybe we can rename this property to initialResourceIdentifier.
| @@ -33,7 +34,8 @@ internal class RumApplicationScope( | |||
| private val memoryVitalMonitor: VitalMonitor, | |||
| private val frameRateVitalMonitor: VitalMonitor, | |||
| private val sessionEndedMetricDispatcher: SessionMetricDispatcher, | |||
| private val sessionListener: RumSessionListener? | |||
| private val sessionListener: RumSessionListener?, | |||
| private val networkSettledResourceIdentifier: InitialResourceIdentifier | |||
There was a problem hiding this comment.
Note
Same, maybe we can rename this property to initialResourceIdentifier.
| @@ -37,6 +38,7 @@ internal class RumSessionScope( | |||
| frameRateVitalMonitor: VitalMonitor, | |||
| private val sessionListener: RumSessionListener?, | |||
| applicationDisplayed: Boolean, | |||
| networkSettledResourceIdentifier: InitialResourceIdentifier, | |||
There was a problem hiding this comment.
Note
Same, maybe we can rename this property to initialResourceIdentifier.
| @@ -40,6 +42,7 @@ internal class RumViewManagerScope( | |||
| private val frameRateVitalMonitor: VitalMonitor, | |||
| internal var applicationDisplayed: Boolean, | |||
| internal val sampleRate: Float, | |||
| internal val networkSettledResourceIdentifier: InitialResourceIdentifier, | |||
There was a problem hiding this comment.
Note
Same, maybe we can rename this property to initialResourceIdentifier.
| @@ -62,8 +63,7 @@ internal open class RumViewScope( | |||
| private val trackFrustrations: Boolean, | |||
| internal val sampleRate: Float, | |||
| private val interactionToNextViewMetricResolver: InteractionToNextViewMetricResolver, | |||
| private val networkSettledMetricResolver: NetworkSettledMetricResolver = | |||
| NetworkSettledMetricResolver(internalLogger = sdkCore.internalLogger) | |||
| private val networkSettledMetricResolver: NetworkSettledMetricResolver | |||
There was a problem hiding this comment.
Note
Same, maybe we can rename this property to initialResourceIdentifier.
| @@ -70,7 +71,8 @@ internal class DatadogRumMonitor( | |||
| memoryVitalMonitor: VitalMonitor, | |||
| frameRateVitalMonitor: VitalMonitor, | |||
| sessionListener: RumSessionListener, | |||
| internal val executorService: ExecutorService | |||
| internal val executorService: ExecutorService, | |||
| internal val networkSettledResourceIdentifier: InitialResourceIdentifier | |||
There was a problem hiding this comment.
Note
Same, maybe we can rename this property to initialResourceIdentifier.
ambushwork
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following the RFC we are introducing the
setNetworkSettledInitialResourceIdentifierAPI as part of theRumConfiguration#Builderin order to provide external control on which resource started in a view will be take partin the
time-to-network-settledmetric computation. The default identifier being used is aTimeBasedResourceIdentifierwith a default threshold set to100ms. This could be re - used by our users in the ConfigurationBuilderby changing thetime intervalto their internal needs.In addition to this this PR contain a small but very important fix in the
RumViewScopewhere we make sure theNetworkSettledMetricResolveris notified for theview stoppedonly if the event was sent for the current view and only once.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)