Supported php84 #2984
Open
Supported php84 #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to ./UPGRADE-1.0.md#php-5-eol, 5.x is no longer supported.
Without it, the installer script could only find the main binary /usr/bin/php because it didn't had a version number included in the path. Inspired by 7e6ff34
|
Note that last time, @PROFeNoM mentioned extra work that was needed on top of this: #2417 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2984 +/- ##
============================================
- Coverage 73.12% 1.96% -71.16%
Complexity 2741 2741
============================================
Files 137 110 -27
Lines 14907 10863 -4044
Branches 992 0 -992
============================================
- Hits 10900 214 -10686
- Misses 3462 10649 +7187
+ Partials 545 0 -545
Flags with carried forward coverage won't be shown. Click here to find out more. see 111 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PROFeNoM
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue that already happened for PHP 8.3: #2417
Also, I'm removing support for PHP 5.
Reviewer checklist