Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-after-free with live-debugger #2989

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Dec 11, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc changed the title Fix user-after-free with debugger Fix user-after-free with live-debugger Dec 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.90%. Comparing base (b928df9) to head (3c85fc7).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2989      +/-   ##
============================================
- Coverage     74.82%   72.90%   -1.92%     
  Complexity     2741     2741              
============================================
  Files           110      137      +27     
  Lines         10863    14978    +4115     
  Branches          0     1016    +1016     
============================================
+ Hits           8128    10920    +2792     
- Misses         2735     3506     +771     
- Partials          0      552     +552     
Flag Coverage Δ
appsec-extension 67.84% <ø> (?)
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b928df9...3c85fc7. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-12-13 11:10:12

Comparing candidate commit 3c85fc7 in PR branch luc/fix-use-after-free-ephemeral-props with baseline commit b928df9 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+6.658µs; +15.242µs] or [+3.594%; +8.227%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟥 execution_time [+1000.000ns; +1000.000ns] or [+100.000%; +100.000%]

@iamluc iamluc force-pushed the luc/fix-use-after-free-ephemeral-props branch from d1f3124 to bad942c Compare December 11, 2024 09:49
@iamluc iamluc force-pushed the luc/fix-use-after-free-ephemeral-props branch from bad942c to acd6c7f Compare December 11, 2024 10:27
@iamluc iamluc marked this pull request as ready for review December 11, 2024 10:49
@iamluc iamluc requested a review from a team as a code owner December 11, 2024 10:49
@iamluc iamluc marked this pull request as draft December 11, 2024 16:35
@iamluc iamluc changed the title Fix user-after-free with live-debugger Fix use-after-free with live-debugger Dec 11, 2024
@iamluc iamluc force-pushed the luc/fix-use-after-free-ephemeral-props branch from dc406ff to 7d0be10 Compare December 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants