Add http.route tag to SymfonyIntegration.php

[cataphract]

Description

Adds http.route to symfony. Supersedes #2710 and #2477

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 55.97%. Comparing base (b928df9) to head (7233cec).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
...DTrace/Integrations/Symfony/SymfonyIntegration.php	0.00%	43 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b928df9) and HEAD (7233cec). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (b928df9)	HEAD (7233cec)
tracer-php	11	10

Additional details and impacted files

@@              Coverage Diff              @@
##             master    #2992       +/-   ##
=============================================
- Coverage     74.82%   55.97%   -18.85%     
- Complexity     2741     2745        +4     
=============================================
  Files           110      137       +27     
  Lines         10863    15015     +4152     
  Branches          0     1016     +1016     
=============================================
+ Hits           8128     8405      +277     
- Misses         2735     6058     +3323     
- Partials          0      552      +552     

Flag	Coverage Δ
appsec-extension	67.84% <ø> (?)
tracer-php	51.49% <0.00%> (-23.33%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...DTrace/Integrations/Symfony/SymfonyIntegration.php	0.00% <0.00%> (-82.86%)	⬇️

... and 46 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b928df9...7233cec. Read the comment docs.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2024-12-17 14:22:00

Comparing candidate commit 7233cec in PR branch glopes/symfony-route with baseline commit b928df9 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceFlushBench/benchFlushTrace

• 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

[github-actions]

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

[PROFeNoM]

Why are we removing those tests from PHP 8.1 up to PHP 8.3? 🤔

[cataphract]

Symfony 5.2 doesn't actually work with those PHP versions. The tests fail with:

[17-Dec-2024 19:40:57 -03] [ddtrace] [warning] Error raised in ddtrace's closure defined at /Users/gustavo.lopes/repos/dd-trace-php/src/DDTrace/Integrations/Symfony/SymfonyIntegration.php:394 for Symfony\Component\HttpKernel\HttpKernel::handle(): Return type of Symfony\Component\Routing\RouteCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /Users/gustavo.lopes/repos/dd-trace-php/tests/Frameworks/Symfony/Version_5_2/vendor/symfony/routing/RouteCollection.php on line 69
 /Users/gustavo.lopes/repos/dd-trace-php/tests/Common/WebFrameworkTestCase.php:74
 /Users/gustavo.lopes/repos/dd-trace-php/tests/Common/MultiPHPUnitVersionAdapter_typed.php:33

[PROFeNoM]

FYI, I can see the following warning/error from our CI: failure.

On a similar note, the Symfony 3.0 (:skull:) tests seems not to have the http.route tag: failure

[estringana]

I am missing tests with optional parameters https://symfony.com/doc/current/routing.html#optional-parameters, more than one locale https://symfony.com/doc/current/routing.html#localized-routes-i18n