Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce memory usage in profiling #2995

Draft
wants to merge 3 commits into
base: levi/thin-str
Choose a base branch
from

Conversation

morrisonlevi
Copy link
Collaborator

Description

Utilizes ThinStr in the ZendFrame to shrink memory. This shrinks each frame from 7 words to 3 words.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link

pr-commenter bot commented Dec 15, 2024

Benchmarks [ profiler ]

Benchmark execution time: 2024-12-16 23:18:19

Comparing candidate commit 5d13085 in PR branch levi/thin-zend-frame with baseline commit 53a8da7 in branch levi/thin-str.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 23 metrics, 7 unstable metrics.

scenario:walk_stack/1

  • 🟥 wall_time [+4.217µs; +4.221µs] or [+35.743%; +35.780%]

scenario:walk_stack/50

  • 🟥 wall_time [+4.236µs; +4.247µs] or [+29.190%; +29.273%]

scenario:walk_stack/99

  • 🟥 wall_time [+4.469µs; +4.474µs] or [+30.895%; +30.928%]

scenario:walk_stack_instructions/1

  • 🟥 instructions [+23.6K instructions; +23.6K instructions] or [+23.572%; +23.575%]

scenario:walk_stack_instructions/50

  • 🟥 instructions [+33.7K instructions; +33.7K instructions] or [+33.355%; +33.356%]

scenario:walk_stack_instructions/99

  • 🟥 instructions [+35.9K instructions; +35.9K instructions] or [+35.404%; +35.421%]

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (53a8da7) to head (5d13085).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             levi/thin-str    #2995   +/-   ##
================================================
  Coverage            74.56%   74.56%           
  Complexity            2750     2750           
================================================
  Files                  111      111           
  Lines                10900    10900           
================================================
  Hits                  8128     8128           
  Misses                2772     2772           
Flag Coverage Δ
tracer-php 74.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a8da7...5d13085. Read the comment docs.

Utilizes ThinStr in the ZendFrame to shrink memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants