Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block signals for more functions #2999

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Dec 17, 2024

Description

Follow-up of #2957

At least 2 customers reported random issues with database connections that seems to be fixed when remote config is disabled.
For one of the reports, the error was EINPROGRESS (Operation now in progress), which could seems unrelated, but actually a bug in PHP (likely fixed by php/php-src#16606) could return this error while the real one is EINTR

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.89%. Comparing base (b928df9) to head (005f7f1).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2999      +/-   ##
============================================
- Coverage     74.82%   72.89%   -1.93%     
  Complexity     2741     2741              
============================================
  Files           110      137      +27     
  Lines         10863    14978    +4115     
  Branches          0     1016    +1016     
============================================
+ Hits           8128    10918    +2790     
- Misses         2735     3508     +773     
- Partials          0      552     +552     
Flag Coverage Δ
appsec-extension 67.84% <ø> (?)
tracer-php 74.80% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b928df9...005f7f1. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-12-17 10:41:27

Comparing candidate commit 005f7f1 in PR branch luc/block-signal-add-funcs with baseline commit b928df9 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-5.022µs; -3.378µs] or [-2.983%; -2.006%]

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-13.471µs; -5.170µs] or [-7.188%; -2.759%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants