Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let standard limiters to work when standalone not enabled #3001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-12-17 14:44:23

Comparing candidate commit df1afe5 in PR branch estringana/change-rate-limiter-standalone with baseline commit 0926c77 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-256.323µs; -91.237µs] or [-7.414%; -2.639%]

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-12.937µs; -4.731µs] or [-6.918%; -2.530%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

@estringana estringana force-pushed the estringana/change-rate-limiter-standalone branch from fc0d9d3 to 0f87461 Compare December 17, 2024 12:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.04%. Comparing base (0926c77) to head (df1afe5).

❗ There is a different number of reports uploaded between BASE (0926c77) and HEAD (df1afe5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0926c77) HEAD (df1afe5)
tracer-php 11 10
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3001       +/-   ##
=============================================
- Coverage     72.74%   56.04%   -16.70%     
  Complexity     2750     2750               
=============================================
  Files           138      138               
  Lines         15060    15060               
  Branches       1026     1026               
=============================================
- Hits          10955     8440     -2515     
- Misses         3546     6061     +2515     
  Partials        559      559               
Flag Coverage Δ
appsec-extension 67.95% <ø> (ø)
tracer-php 51.49% <ø> (-23.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0926c77...df1afe5. Read the comment docs.

@estringana estringana force-pushed the estringana/change-rate-limiter-standalone branch from 0f87461 to df1afe5 Compare December 17, 2024 14:15
@estringana estringana marked this pull request as ready for review December 17, 2024 16:17
@estringana estringana requested review from a team as code owners December 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants