Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debugger] Update debugger system tests scenarios #4203

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

shurivich
Copy link
Contributor

@shurivich shurivich commented Dec 8, 2024

What does this PR do?
Update debugger system tests scenarios.
Depends on DataDog/system-tests#3616

Motivation:
Sync with removed/added tests

Change log entry
None

Additional Notes:

How to test the change?

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

Thank you for updating Change log entry section 👏

Visited at: 2024-12-08 11:07:20 UTC

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (c07a8d4) to head (a18e002).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4203      +/-   ##
==========================================
- Coverage   97.77%   97.75%   -0.02%     
==========================================
  Files        1357     1357              
  Lines       81973    81974       +1     
  Branches     4168     4168              
==========================================
- Hits        80145    80137       -8     
- Misses       1828     1837       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 8, 2024

Benchmarks

Benchmark execution time: 2024-12-10 10:03:09

Comparing candidate commit a18e002 in PR branch shurivich/system_tests with baseline commit c07a8d4 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+9426.804op/s; +10098.259op/s] or [+6.062%; +6.493%]

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-3521.363op/s; -3439.606op/s] or [-10.570%; -10.325%]

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-9600.774op/s; -9189.149op/s] or [-8.003%; -7.660%]

@shurivich shurivich changed the title [Debugger] Update debugger scenarios [Debugger] Update debugger system tests scenarios Dec 8, 2024
@shurivich shurivich self-assigned this Dec 10, 2024
@shurivich shurivich added ci-app CI product for test suite instrumentation and removed ci-app CI product for test suite instrumentation labels Dec 10, 2024
@shurivich shurivich force-pushed the shurivich/system_tests branch from 73c6afa to 8624186 Compare December 10, 2024 09:39
@shurivich shurivich force-pushed the shurivich/system_tests branch from 8624186 to a18e002 Compare December 10, 2024 09:40
@shurivich shurivich marked this pull request as ready for review December 10, 2024 10:52
@shurivich shurivich requested a review from a team as a code owner December 10, 2024 10:52
@shurivich shurivich requested a review from p-datadog December 10, 2024 11:46
@p-datadog p-datadog added the dev/internal Other internal work that does not need to be included in the changelog label Dec 10, 2024
@p-datadog
Copy link
Member

I am repairing the system tests side in DataDog/system-tests#3531, I think this PR is OK to go as is and until DataDog/system-tests#3531 is merged the DI tests aren't actually running anyway (with or without this PR being merged).

@p-datadog p-datadog merged commit b985e32 into master Dec 10, 2024
339 checks passed
@p-datadog p-datadog deleted the shurivich/system_tests branch December 10, 2024 20:37
@github-actions github-actions bot added this to the 2.9.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants