Aerospike agent and dashboards #19188

mphanias · 2024-12-04T16:39:03Z

What does this PR do?

Modified the aerospike integration to include all the metrics exposed by aerospike-pormetheus-exporter and multiple dashboard consuming the exported metrics.

Motivation

Expanding Metric Collection and Dashboards, we want to ensure all Aerospike metrics are available in datadog, so customers can have better visibility and provide actionable insights for key metrics, including performance, latency, and resource utilization.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

modified check and metrics python scripts - -- to include all aerospike metrics most as gauge -- latency metrics are added as histograms added new dashboard covering key aerospike metrics required to be monitored includes, - cluster, node, namespace, sindex, sets, users, xdr, basic system-info and latencies

added CHANGELOG.md with details added and changed.

updated Aerospike pulgin version in about script

reverted the aerospike version to 4.0.0

reverted CHANGELOG.md to earlier and actual version generated changelog using ddev package from pypi with command "ddev release changelog new"

corrected the changelog files location

updated the correct PR number

github-actions · 2024-12-04T18:10:54Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

incorporated lint feedback and removed unnessary spaces

github-actions · 2024-12-04T18:19:45Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

removed unneceddary spaces at the end of the line as suggested in lint check

github-actions · 2024-12-04T18:25:20Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

removed unnecessary blank lines reported by lint at the end of file

github-actions · 2024-12-04T18:40:17Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

corrected comments

github-actions · 2024-12-04T18:44:31Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

codecov · 2024-12-04T18:48:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (cd26fe5) to head (7711ad1).

Additional details and impacted files

Flag	Coverage Δ
activemq	`?`
aerospike	`86.29% <100.00%> (+15.57%)`	⬆️
cassandra	`?`
hive	`?`
hivemq	`?`
hudi	`?`
ignite	`?`
jboss_wildfly	`?`
kafka	`?`
presto	`?`
solr	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

renamed label cluster_name as aerospike_cluster as it is forbidden as per github checks,

github-actions · 2024-12-04T19:04:40Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

added mapping for cluster_name to aerospike_cluster - updated check.py

github-actions · 2024-12-04T19:13:09Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

github-actions · 2024-12-04T21:28:36Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

github-actions · 2024-12-04T21:28:50Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

updated the latest metric details in common.py

github-actions · 2024-12-04T22:19:20Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

removed unnecessary spaces reported by lint

github-actions · 2024-12-04T22:26:17Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

made suggesting given in lint

github-actions · 2024-12-04T23:03:35Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

fixed lint comments

github-actions · 2024-12-04T23:09:29Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

reverted old metric names used in unit tests

github-actions · 2024-12-04T23:33:06Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

incorporated lint feedback

github-actions · 2024-12-04T23:41:03Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

added metric to prometheus.txt

github-actions · 2024-12-05T00:04:57Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

added metric in metadata.csv

github-actions · 2024-12-05T00:27:29Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

corrected the metric name by adding proper prefix

github-actions · 2024-12-05T00:30:58Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

corrected metadata using ddev command

github-actions · 2024-12-05T00:52:49Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

corrected labels in the metric name

github-actions · 2024-12-05T01:01:18Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

corrected labels syntax issue

github-actions · 2024-12-05T01:12:44Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

added metrics to prometheus txt and metadata.csv

github-actions · 2024-12-05T01:31:03Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

added batch metrics to metadata and prometheus.txt

github-actions · 2024-12-05T01:58:02Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

mphanias and others added 3 commits November 26, 2024 10:57

reverted aerospike_cluster label to cluster_name

e0b2898

Replaced aerospike_cluster label with cluster_name label

6e5f48f

mphanias requested review from a team as code owners December 4, 2024 16:39

datadog-assets bot added agent/review-requested ecosystems/review-requested product/review-requested labels Dec 4, 2024

mphanias and others added 2 commits December 4, 2024 22:13

Merge branch 'master' into aerospike-agent-and-dashboards

5e08a12

aerospike-agent-and-dashboards

1bc9d8e

added CHANGELOG.md with details added and changed.

datadog-assets bot added the docs/review-requested label Dec 4, 2024

mphanias added 5 commits December 4, 2024 23:17

aerospike-agent-and-dashboards

5173717

updated Aerospike pulgin version in about script

aerospike-agent-and-dashboards

3df2e42

reverted the aerospike version to 4.0.0

aerospike-agent-and-dashboards

abaa3fa

reverted CHANGELOG.md to earlier and actual version generated changelog using ddev package from pypi with command "ddev release changelog new"

aerospike-agent-and-dashboard

81dc631

corrected the changelog files location

aerospike-agent-and-dashboard

e9c476c

updated the correct PR number

aerospike-agent-and-dashboard

b352d12

incorporated lint feedback and removed unnessary spaces

aerospike-agent-and-dashboard

b298492

removed unneceddary spaces at the end of the line as suggested in lint check

aerospike-agent-and-dashboard

33d85a9

removed unnecessary blank lines reported by lint at the end of file

aerospike-agent-and-dashboards

60b80bf

corrected comments

aerospike-agent-and-dashboard

058f0d4

renamed label cluster_name as aerospike_cluster as it is forbidden as per github checks,

aerospike-agent-and-dashboards

26a128c

added mapping for cluster_name to aerospike_cluster - updated check.py

aerospike-agent-and-datacenter

5f9a6af

updated the latest metric details in common.py

aerospike-agent-and-dashboard

5307971

removed unnecessary spaces reported by lint

aerospike-agent-and-dashboard

fcdbc07

made suggesting given in lint

aerospike-agent-and-dashboard

498ed89

fixed lint comments

aerospike-agent-and-dashboard

3ae7e13

reverted old metric names used in unit tests

aerospike-agent-and-dashboard

e0eb578

incorporated lint feedback

aerospike-agent-and-dashboard

1a0055e

added metric to prometheus.txt

aerospike-agent-and-dashboard

fb47e68

added metric in metadata.csv

aerospike-agent-and-dashboard

7023501

corrected the metric name by adding proper prefix

aerospike-agent-and-dashboards

b2f559b

corrected metadata using ddev command

aerospike-agent-and-dashboards

67c8b39

corrected labels in the metric name

aerospike-agent-and-dashboards

fbb6b6c

corrected labels syntax issue

aerospike-agent-and-dashboards

9ea02ea

added metrics to prometheus txt and metadata.csv

aerospike-agent-and-dashboards

7711ad1

added batch metrics to metadata and prometheus.txt

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aerospike agent and dashboards #19188

Aerospike agent and dashboards #19188

mphanias commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

codecov bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

Aerospike agent and dashboards #19188

Are you sure you want to change the base?

Aerospike agent and dashboards #19188

Conversation

mphanias commented Dec 4, 2024

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

codecov bot commented Dec 4, 2024 • edited Loading

Codecov Report

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

codecov bot commented Dec 4, 2024 •

edited

Loading