Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to system_health/event_file when querying deadlocks #19189

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

nenadnoveljic
Copy link
Contributor

@nenadnoveljic nenadnoveljic commented Dec 4, 2024

What does this PR do?

If the datadog XE session isn't created, the agent will retrieve deadlocks from system_health/event_file.

Motivation

Some customers can't or prefer not to create dedicated XE sessions. We use event_file over ring_buffer to avoid truncating recent events, but datadog XE session remains the preferred option for better performance.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.77%. Comparing base (14c88c4) to head (1fc1079).
Report is 4 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.15% <88.00%> (+9.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@nenadnoveljic nenadnoveljic added qa/skip-qa Automatically skip this PR for the next QA team/database-monitoring labels Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

1 similar comment
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@nenadnoveljic nenadnoveljic added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit cd26fe5 Dec 4, 2024
38 checks passed
@nenadnoveljic nenadnoveljic deleted the nenadnoveljic/deadlocks-file branch December 4, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants