Tidy PR up

DataDog · Dec 13, 2024 · 55b4451 · 55b4451
1 parent d863cbb
commit 55b4451
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/manifests/php.yml b/manifests/php.yml
@@ -148,13 +148,13 @@ tests/:
     rasp/:
       test_cmdi.py: missing_feature
       test_lfi.py:
-        Test_Lfi_BodyJson: v1.3.0
-        Test_Lfi_BodyUrlEncoded: v1.3.0
-        Test_Lfi_BodyXml: v1.3.0
-        Test_Lfi_Mandatory_SpanTags: v1.3.0
-        Test_Lfi_Optional_SpanTags: v1.3.0
-        Test_Lfi_StackTrace: v1.3.0
-        Test_Lfi_Telemetry: v1.3.0
+        Test_Lfi_BodyJson: v1.3.1
+        Test_Lfi_BodyUrlEncoded: v1.3.1
+        Test_Lfi_BodyXml: v1.3.1
+        Test_Lfi_Mandatory_SpanTags: v1.3.1
+        Test_Lfi_Optional_SpanTags: v1.3.1
+        Test_Lfi_StackTrace: v1.3.1
+        Test_Lfi_Telemetry: missing_feature
         Test_Lfi_UrlQuery: v1.3.0
       test_shi.py: missing_feature
       test_sqli.py: missing_feature

diff --git a/tests/appsec/rasp/test_lfi.py b/tests/appsec/rasp/test_lfi.py
@@ -130,6 +130,7 @@ class Test_Lfi_Optional_SpanTags:
     def setup_lfi_span_tags(self):
         self.r = weblog.get("/rasp/lfi", params={"file": "../etc/passwd"})
 
+    @bug(library="php", reason="APPSEC-54761")
     def test_lfi_span_tags(self):
         validate_span_tags(
             self.r, expected_metrics=["_dd.appsec.rasp.duration_ext", "_dd.appsec.rasp.rule.eval",],

diff --git a/utils/build/docker/php/app.sh b/utils/build/docker/php/app.sh
@@ -1,3 +1,3 @@
 #!/bin/bash
 
-#Nothing to do here. This file is to allow --sleep execution
+#Nothing to do here. This file is to allow --sleep execution
diff --git a/utils/build/docker/php/common/rasp/lfi.php b/utils/build/docker/php/common/rasp/lfi.php
@@ -20,4 +20,4 @@
 
 file_get_contents($file);
 
-echo "Hello, LFI!";
+echo "Hello, LFI!";
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,4 +20,4 @@

		file_get_contents($file);

		echo "Hello, LFI!";
		echo "Hello, LFI!";