Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize python build time #1331

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

cbeauchesne
Copy link
Collaborator

Description

  • Use python-slim as base image
  • use pre-build base image for python weblogs

See #562

Motivation

Build time !

Reviewer checklist

  • If this PR modifies anything else than strictly the default scenario, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

@cbeauchesne cbeauchesne force-pushed the cbeauchesne/optimize-python-build branch from 31e2169 to 8835d8e Compare July 3, 2023 08:15
@cbeauchesne cbeauchesne marked this pull request as ready for review July 3, 2023 08:37
@cbeauchesne cbeauchesne requested review from a team as code owners July 3, 2023 08:37
@cbeauchesne cbeauchesne requested review from juanjux and Yun-Kim July 3, 2023 08:37
@smola
Copy link
Member

smola commented Jul 3, 2023

It seems the base images wouldn't be built and pushed by CI on merges. What would be the workflow when there are changes to the base images?

@cbeauchesne
Copy link
Collaborator Author

They are actually very stable. For now, we'll build/push them locally if needed.

If it turns out that it happen more often than I anticpate, it will be something like an optionnal job triggered by a label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants