Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby:Document and skip failing tests #3297

Closed
wants to merge 1 commit into from
Closed

Ruby:Document and skip failing tests #3297

wants to merge 1 commit into from

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Oct 23, 2024

Motivation

These two tests are failing in main.

This PR skips and documents them, capturing them in Jira.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@marcotc marcotc requested review from mabdinur and a team as code owners October 23, 2024 17:49
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to mark them as bug instead of missing_feature?

Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong, those change are also in #3279 ?

@ZStriker19
Copy link
Contributor

If I'm not wrong, those change are also in #3279 ?

We wanted to do it separately originally but let's just close this and merge #3279

@ZStriker19
Copy link
Contributor

Closing because changes are made/updated in #3279

@ZStriker19 ZStriker19 closed this Oct 24, 2024
@cbeauchesne cbeauchesne deleted the skip-ruby branch October 24, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants