Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix buildpack lib-injection image #3542

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

randomanderson
Copy link
Contributor

@randomanderson randomanderson commented Nov 25, 2024

Motivation

Multiple issues with the buildpack image meant it always failed. These failures went unnoticed because the test is marked as flaky.

Changes

Fixes were:

  • Using the docker.io proxy for the buildpacks
  • Copying the correct docker-compose file
  • Starting the docker daemon
  • Removing flaky markers

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@randomanderson randomanderson force-pushed the landerson/fix-java-buildpack branch from 76dd195 to cc66204 Compare December 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants