-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sinon: bump version to 12.0.1 #20528
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksercs
force-pushed
the
bump_sinon__22_1
branch
from
December 14, 2021 07:48
bf09c21
to
48d36e6
Compare
I close this PR, because after update we have big problems with timers. In the previous sinon versions scarcely planned nullish settimeout was ticked on the current iteration (see this code). But now nullish settimeout is planned for a one ms from now: proof. We have some nullish settimeouts (expecially, in grids), so tests are in a big trouble. Sample of broken scenarios:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration points:
useFakeXMLHttpRequest
is used (nise issue, sinon default value specifying code )callTimer
,firstTimerInRange
, etc