Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use any-cloud-storage to abstract artifact storage #104

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

nalbion
Copy link
Contributor

@nalbion nalbion commented Feb 14, 2024

Pull Request

Description

Use https://github.com/nalbion/any-cloud-storage to abstract storage of artifacts

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

  • My code adheres to the project's coding standards and style guidelines.

  • I have tested my changes thoroughly, including unit tests where applicable.

  • I have updated the documentation to reflect any changes made in this pull request.

  • My branch is up-to-date with the latest changes from the main branch.

  • I have received code review feedback and addressed any comments or concerns.

References, Fixes and Closes

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
agentprotocolai ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 6:46am

@jzanecook
Copy link
Collaborator

I believe these changes would not be a standard agent protocol SDK that's 1:1 with the spec. For changes to the spec, there needs to be an RFC written out that details the changes.

However, I can see this being useful for the js sdk, and I'm thinking that what we could do here is take some of these changes and incorporate it into some example agents. If you can take a look at the config options RFC in the V2 branch and see if that "changes the game" per se for your implementations.

@nalbion
Copy link
Contributor Author

nalbion commented Mar 12, 2024

@jzanecook I don't think that the implementation of createArtifact(), registerCreateArtifact() and registerGetTaskArtifact() have anything to do with the spec.

I'd be happy to move AnyCloudArtifactStorage and ArtifactStorageFactory into a README or examples and remove the dependency on any-cloud-storage. Maybe the example could show how artifact_provider could be used to configure the storage for each request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants