FIX add option to use master mail server for scripts system #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Feb 17, 2023
| @@ -704,6 +704,8 @@ allowed_hosts=127.0.0.1,ipofmasterserver | |||
| [email protected] | |||
| # email supervision | |||
| [email protected] | |||
| # Option to use mail server of master server (for scripts system) | |||
| # usemastermailserver=1 | |||
There was a problem hiding this comment.
I don't think we must just put a flag to say use master server. Because on master server, key (like smtp pass) is encrypted and only the master should be able to uncrypt so it is protected if database is stolen.
If you say to use the pass of the master, it also means you must store the decode key (so $dolibarr_main_instance_unique_id of the master) on the deployment server. This means the pass to encrypt master database fields become public.
I think we should instead store inside the .conf file, the data to use to send email (so the mode to send email, the smtp address and port, login/pass) so only smtp data are leaks on the deployment server instead of all encrypted data of the master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.