Use signed integers for outside and inside temperatures

DomiStyle · Nov 12, 2021 · 8aae263 · 8aae263
1 parent 8bfd463
commit 8aae263
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/components/panasonic_ac/esppac.cpp b/components/panasonic_ac/esppac.cpp
@@ -59,7 +59,7 @@ void PanasonicAC::read_data() {
   }
 }
 
-void PanasonicAC::update_outside_temperature(uint8_t temperature) {
+void PanasonicAC::update_outside_temperature(int8_t temperature) {
   if (temperature > TEMPERATURE_THRESHOLD) {
     ESP_LOGW(TAG, "Received out of range outside temperature: %d", temperature);
     return;
@@ -70,7 +70,7 @@ void PanasonicAC::update_outside_temperature(uint8_t temperature) {
         temperature);  // Set current (outside) temperature; no temperature steps
 }
 
-void PanasonicAC::update_current_temperature(uint8_t temperature) {
+void PanasonicAC::update_current_temperature(int8_t temperature) {
   if (temperature > TEMPERATURE_THRESHOLD) {
     ESP_LOGW(TAG, "Received out of range inside temperature: %d", temperature);
     return;

diff --git a/components/panasonic_ac/esppac.h b/components/panasonic_ac/esppac.h
@@ -81,8 +81,8 @@ class PanasonicAC : public Component, public uart::UARTDevice, public climate::C
 
   void read_data();
 
-  void update_outside_temperature(uint8_t temperature);
-  void update_current_temperature(uint8_t temperature);
+  void update_outside_temperature(int8_t temperature);
+  void update_current_temperature(int8_t temperature);
   void update_target_temperature(uint8_t raw_value);
   void update_swing_horizontal(const std::string &swing);
   void update_swing_vertical(const std::string &swing);