Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphBLAS/rmm_wrap: Slightly overhaul build rules #543

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mmuetzel
Copy link
Contributor

Rename target to RMM_wrap and export it with the GraphBLASTargets.
Find package CUDAToolkit and link to CMake target instead of CUDA runtime library name.
Fix error when configured with ENABLE_SHARED_LIBS=OFF.

I can't test this change locally (no working CUDA yet). But I hope it will help for #541.

Rename target to `RMM_wrap` and export it with the GraphBLASTargets.
Find package CUDAToolkit and link to CMake target instead of CUDA runtime library name.
Fix error when configured with `ENABLE_SHARED_LIBS=OFF`.
@DrTimothyAldenDavis
Copy link
Owner

Thanks! I'll merge it in and test it out, both here and in the draft GraphBLAS 9.0.1 on the GraphBLAS repo.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit d6ab220 into DrTimothyAldenDavis:dev2 Nov 28, 2023
23 checks passed
@DrTimothyAldenDavis
Copy link
Owner

Works!

I had to make some other fixes, by back-porting those fixes from the draft GraphBLAS 9.0.1. But this gets me back to where I was, in both v8.3.0 and v9.0.1.

I'll post those to v8.3.0 here, even though the CUDA kernels are fully functional yet. But at least now the CUDA and RMM_WRAP libraries both build OK in v8.3.0.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants