Add build and test stage #37
Conversation
.github/workflows/build-and-test.yml
Outdated
| name: Build and test | ||
| on: | ||
| pull_request: | ||
| branches: [ "main" ] |
There was a problem hiding this comment.
why restricted only to main branch?
There was a problem hiding this comment.
I have no explaination for that. Should build be performed for every commit?
.github/workflows/build-and-test.yml
Outdated
| run: ansible-galaxy collection install dynatrace-oneagent* | ||
| - name: Running sanity test | ||
| run: pushd ~/.ansible/collections/ansible_collections/dynatrace/oneagent && ansible-test sanity && popd | ||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
publishing should be done at least as a separate step
There was a problem hiding this comment.
What is the reason for that? I don't think putting it to separate job and create dependency between uploading and building just for a sake of separating them has any meaning
.github/workflows/build-and-test.yml
Outdated
| with: | ||
| python-version: '3.10' | ||
| - name: Installing dependencies | ||
| run: pip install ansible |
There was a problem hiding this comment.
Add step for downloading https://ca.dynatrace.com/dt-root.cert.pem
WStechura
force-pushed
the
add-github-action-for-sanity-check
branch
3 times, most recently
from
a373c9d to
e0c1e20
Compare
| @@ -0,0 +1,26 @@ | |||
| # Copyright 2023 Dynatrace LLC | |||
There was a problem hiding this comment.
| # Copyright 2023 Dynatrace LLC | |
| # Copyright 2024 Dynatrace LLC |
| build-and-test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
| name: Build, test and upload | ||
| on: | ||
| pull_request: | ||
| types: [ 'closed' ] |
There was a problem hiding this comment.
why not just main branch? What is the difference?
There was a problem hiding this comment.
So that the artifact is only published once the PR is closed
There was a problem hiding this comment.
What if PR is closed without merging to main branch? Shouldn't we trigger upload only on main branch?
| workflow_dispatch: | ||
|
|
||
| env: | ||
| FILES_DIR: roles/oneagent/files |
There was a problem hiding this comment.
duplicated in build-and-test.yaml
| steps: | ||
| - name: Download certificate | ||
| shell: bash | ||
| run: mkdir $FILES_DIR && wget https://ca.dynatrace.com/dt-root.cert.pem -P $FILES_DIR |
There was a problem hiding this comment.
It's worth to add $FILES_DIR directory creation as a separate step, because it may fail.
| run: mkdir $FILES_DIR && wget https://ca.dynatrace.com/dt-root.cert.pem -P $FILES_DIR | ||
| - name: Building the collection | ||
| shell: bash | ||
| run: ansible-galaxy collection build . |
There was a problem hiding this comment.
| run: ansible-galaxy collection build . | |
| run: ansible-galaxy collection build . -vvv |
ansible-galaxy collection build . does not generally provide much information.
| - name: Download certificate | ||
| shell: bash | ||
| run: mkdir $FILES_DIR && wget https://ca.dynatrace.com/dt-root.cert.pem -P $FILES_DIR | ||
| - name: Building the collection |
There was a problem hiding this comment.
Please keep to the previously estabilished naming convention.
Building the collection → Build the collection
Installing the collection → Install the collection
etc.
| name: Build and test | ||
| on: | ||
| pull_request: | ||
| branches: [ "*" ] |
There was a problem hiding this comment.
When you want to run a given workflow on all branches, you don't need to specify them. Following will work:
on:
pull_request:
push:
workflow_dispatch:
workflow_call:
There was a problem hiding this comment.
In such scenario, push will work also on tags
| workflow_call: | ||
|
|
||
| env: | ||
| FILES_DIR: roles/oneagent/files |
There was a problem hiding this comment.
| FILES_DIR: roles/oneagent/files | |
| CERTIFICATE_DIR: roles/oneagent/files |
| name: Build, test and upload | ||
| on: | ||
| pull_request: | ||
| branches: [ 'main' ] |
There was a problem hiding this comment.
it should be:
push:
branches:
- main
since we cannot open a PR on main branch
WStechura
force-pushed
the
add-github-action-for-sanity-check
branch
from
787b2c8 to
27ed92c
Compare
No description provided.