Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACT: Manifest classes #18

Closed
wants to merge 2 commits into from
Closed

REFACT: Manifest classes #18

wants to merge 2 commits into from

Conversation

carlwilson
Copy link
Member

  • eark_validator/cli/app.py:
    • validation now uses eark_validator.model.ValidationReport module;
    • improved argparse docs a little;
    • updated epilog date;
  • eark_validator/infopacks/manifest.py:
    • FileItem and Manifest types moved to appropriate model modules;
    • ManifestEntries and Manifests classes now hold API/factory methods for above;
    • no more Checksums from METS files;
    • uses Path rather than str for file paths;
  • eark_validator/mets.py b/eark_validator/mets.py:
    • METS validation moved to MetsFiles class;
    • use FileItem rather than FileEntry types for file lists;
    • utility methods for FileEntry added;
  • added file headers where missing;
  • added a SchematronRuleset.get_reports() genrator method;
  • improved type hints here and there;
  • better/refactored tests; and
  • fixed imports post-refactoring.

@carlwilson
Copy link
Member Author

Subsumed by quick merge of a subsequent PR

@carlwilson carlwilson closed this Feb 20, 2024
@carlwilson carlwilson deleted the refact/manifests branch February 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant