Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACT: Final Manifest tweaks plus minor fixes #19

Closed
wants to merge 2 commits into from
Closed

REFACT: Final Manifest tweaks plus minor fixes #19

wants to merge 2 commits into from

Conversation

carlwilson
Copy link
Member

  • added pickle based serialisation and deserialisation for Manifest class;
  • manifests can now be validated against an alternative root;
  • fixed faulty | as or in MetsFiles.from_file() method;
  • model MetsFile.default_ns is now a dictionary of namespace prefixes and URIs;
  • fixed handling of relative paths during Manifest creation/validation;
  • improved testing of manifest classes; and
  • typehints here and there.

@carlwilson carlwilson changed the base branch from refact/manifests to integration February 9, 2024 12:13
@carlwilson carlwilson marked this pull request as draft February 9, 2024 12:14
@carlwilson carlwilson marked this pull request as ready for review February 9, 2024 14:01
@carlwilson
Copy link
Member Author

Subsumed by quick merge of a subsequent PR

@carlwilson carlwilson closed this Feb 20, 2024
@carlwilson carlwilson deleted the refact/mets branch February 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrendignam darrendignam Awaiting requested review from darrendignam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carlwilson