-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply fix for count of group by query #13
base: master
Are you sure you want to change the base?
Conversation
Looking at the Linux job on Travis, we see that this generates a new error when running the tests:
|
@OskarPersson Any idea what in this would impact FK constraints? Admittedly, it's a bit beyond my internal knowledge of MSSQL/DB backends, but I don't mind plugging away if I have a general direction. On a working level, the patch seems to address a few issues and I haven't had any issue with M2M fields in my tests (although clearly there are issues somewhere). |
I have now tried to run this locally and it seems that test_alter_field_m2m is just a "flaky" test with this library, will have to look into that separately, i.e. we can ignore this error here. Though I would prefer to see some change in the test results before merging this, ensuring that this works as it should. |
This addresses the issues I raised in #12 and is simply reapply a fix proposed upstream at nattster@b095b20 and michiya@761a3a8 that didn't seem to make it into this fork.