Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data:navitha2255 #10072

Closed

Conversation

navitha2255
Copy link

@navitha2255 navitha2255 commented Jan 1, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Jan 1, 2024
Copy link
Member

@kkrishguptaa kkrishguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! You have created an incorrect profile:

  1. the json syntax is invalid, you have missed quotes and some places
  2. You used eddie's links and avatar, please update with your own
  3. The extension for the json has a typo, it should navitha2255.json

You can refer to documentation to fix these issues or if you would like you could even use the new BioDrop Forms to fill it without working with JSON (recommended). Let me know if you need any help

data/navitha2255.jsomn Outdated Show resolved Hide resolved
data/navitha2255.jsomn Outdated Show resolved Hide resolved
data/navitha2255.jsomn Outdated Show resolved Hide resolved
"bio":"iam a frontend developer",
"links":[
{ "name":"follow me on twitter",
"url":https://twitter.com/eddiejaoude",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this with your own twitter account.

You are also missing a " in front of https

Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made most of the changes needed for the JSON to pass, but before we can merge your PR as mentioned in another comment please

  • update the Twitter link so that it is your own
  • change the file name to have json and the end and not jsomn

@SaraJaoude SaraJaoude mentioned this pull request Jan 2, 2024
6 tasks
@SaraJaoude
Copy link
Member

Please see my comments here.

If you need help with editing a PR please check out this documentation and come and chat to us on the EddieHub Discord.

@SaraJaoude
Copy link
Member

We look forward to seeing your Profile on BioDrop, but as there is no recent activity from you to make the changes suggested I am going to close this pull request.

We hope you will raise a new pull request to create your Profile and when you do, you might want to take a look at these Docs which will help with the suggested changes the maintainers have proposed.

Please remember you can also create your Profile using Forms.

@SaraJaoude SaraJaoude closed this Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants