Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic Descriptor Blinding Keys ELIP #8

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Deterministic Descriptor Blinding Keys ELIP #8

merged 1 commit into from
Jan 15, 2024

Conversation

LeoComandini
Copy link
Contributor

No description provided.

@LeoComandini LeoComandini force-pushed the 2023-11-deterministic-blinding-key branch from 0a275cc to abae81a Compare November 17, 2023 14:21
@LeoComandini LeoComandini mentioned this pull request Nov 17, 2023
Merged
@LeoComandini LeoComandini force-pushed the 2023-11-deterministic-blinding-key branch 4 times, most recently from e1ad3af to 1103a13 Compare November 18, 2023 21:09
jgriffiths
jgriffiths reviewed Nov 20, 2023
View reviewed changes
elip-deterministic-blinding-key.mediawiki Outdated Show resolved Hide resolved
elip-deterministic-blinding-key.mediawiki Outdated Show resolved Hide resolved
elip-deterministic-blinding-key.mediawiki Outdated Show resolved Hide resolved
elip-deterministic-blinding-key.mediawiki Outdated Show resolved Hide resolved
elip-deterministic-blinding-key.mediawiki Outdated Show resolved Hide resolved
elip-deterministic-blinding-key.mediawiki Outdated Show resolved Hide resolved
@LeoComandini LeoComandini force-pushed the 2023-11-deterministic-blinding-key branch 3 times, most recently from 0b07531 to a0fab33 Compare November 23, 2023 07:57
@LeoComandini LeoComandini changed the title WIP: Deterministic Descriptor Blinding Keys ELIP Deterministic Descriptor Blinding Keys ELIP Nov 23, 2023
@LeoComandini LeoComandini force-pushed the 2023-11-deterministic-blinding-key branch from a0fab33 to f18dffb Compare November 23, 2023 09:01
@LeoComandini LeoComandini force-pushed the 2023-11-deterministic-blinding-key branch 2 times, most recently from aff098d to c52c80d Compare November 24, 2023 06:14
@jgriffiths
Copy link

LGTM thanks, ack.

@apoelstra
Copy link
Member

c52c80d lgtm. Just two minor comments.

@apoelstra
Copy link
Member

Assigned ELIP 151.

Having said this, my original vision was that people would achieve this by choosing otherwise-unused BIP32 paths and then combining their keys using musig or something. But given that this is currently unspecified (ELIP 150 says Later extensions to this ELIP may specify alternate expressions...) I think this is a simple and good alternative.

@LeoComandini
Copy link
Contributor Author

Addressed review comments and used assigned elip number in the last commit, will squash it later

@apoelstra
Copy link
Member

Looks great!

@LeoComandini
Copy link
Contributor Author

will squash and update after #9 is merged (or abandoned/nacked)

@LeoComandini LeoComandini force-pushed the 2023-11-deterministic-blinding-key branch from 7a57995 to 59dae9f Compare December 21, 2023 11:42
@LeoComandini
Copy link
Contributor Author

Rebased, updated and squashed. Also updated reference impl ElementsProject/elements-miniscript#61

apoelstra
apoelstra approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 59dae9f

apoelstra added a commit to ElementsProject/elements-miniscript that referenced this pull request Jan 9, 2024
@apoelstra
Merge #61: Add ELIP-deterministic-descriptor-blinding-key module
259f7c4 
34005bc Add ELIP-151 module (Leonardo Comandini)

Pull request description:

  Reference implementation for ElementsProject/ELIPs#8

ACKs for top commit:
  apoelstra:
    ACK 34005bc

Tree-SHA512: 8f376d246f6240820606dc555401e94bfadc92614644c3eeafde57674bc62b8e20cde766632540325ceb4e35e51a7006d9bdf175e5b9eb3948a5f5fe56f137eb
@LeoComandini
Copy link
Contributor Author

@apoelstra do we need more work/review on this? or it can be merged? related ref impl was merged ElementsProject/elements-miniscript#61

@apoelstra apoelstra merged commit ff81f6a into ElementsProject:main Jan 15, 2024
@apoelstra
Copy link
Member

I think we can merge it.

@LeoComandini LeoComandini deleted the 2023-11-deterministic-blinding-key branch February 7, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCasatta RCasatta RCasatta left review comments

@jgriffiths jgriffiths jgriffiths left review comments

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeoComandini @jgriffiths @apoelstra @RCasatta