CT descriptor: remove generic from blinding key #59
Conversation
|
Yeah, this solution seems good to me. It's not great but nothing I could come up with was great either. I'd like to fix CI though before moving forward on this. |
LeoComandini
force-pushed
the
2023-10-12-confidential-descriptor-key
branch
from
f9d6655 to
51e7f22
Compare
|
Proposed additional test vectors for ELIP-150 View Descriptor with wildcard:
Non-View Descriptor with wildcard:
|
| .ok() | ||
| .ok_or(ConversionError::HardenedChild)?, |
There was a problem hiding this comment.
I did the same done in DescriptorPublicKey::at_derivation_index...
https://github.com/ElementsProject/elements-miniscript/blob/master/src/descriptor/key.rs#L632
The generic was only used by the `Bare` variant, which was inconsistent with its corresponding "secret" variant, `View`. The generic could be used to handle the conversion from `ConfidentialDescriptor<DescriptorPublicKey>` to `Descriptor<DefiniteDescriptorKey>`, specifically making sure that the descriptor blinding key does not have wildcards. For the `Bare` variant this could be done, but this cannot happen for the `View` variant, since we don't have the definite version of `DescriptorSecretKey`.
LeoComandini
force-pushed
the
2023-10-12-confidential-descriptor-key
branch
from
51e7f22 to
f4be6af
Compare
@apoelstra rebased and CI is now green |
|
Looks good to me. Obviously there are still some open API questions about doing derivations but the result of this is much better than the existing code. |
The generic was only used by the
Barevariant, which was inconsistent with its corresponding "secret" variant,View.The generic could be used to handle the conversion from
ConfidentialDescriptor<DescriptorPublicKey>toDescriptor<DefiniteDescriptorKey>, specifically making sure that the descriptor blinding key does not have wildcards.For the
Barevariant this could be done, but this cannot happen for theViewvariant, since we don't have the definite version ofDescriptorSecretKey.The proposed solution consists in:
ConfidentialDescriptor::at_derivation_indexthat "removes" wildcards from both the "bitcoin" descriptor and the descriptor blinding key. This makes deriving an address from a CT descriptor with wildcards less cumbersome.Key::to_public_key(&self, secp, spk)to return aResultand error ifKeyhas some wildcards. This will fix the casect(xprv/*,desc)which is currently broken.