descriptor: drop to_string_no_chksum method
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method has been made redundant by the `{:#}` display specifier
since 7577e8c two years ago. It is
poorly named, inefficient since it always requires allocating a
`String`, and also broken because it uses debug display for keys.
All of our unit tests were converted over to use :# which is why it
wasn't noticed that this method didn't work.
Fixes ElementsProject#34
Fixes ElementsProject#85
delta1
approved these changes
Jun 18, 2024
RCasatta
approved these changes
Sep 24, 2024
|
@apoelstra I can't merge here |
|
Added your ability to merge. Merged this after testing merge commit. There are linter failures on master right now which I'll fix in another PR (for now I disabled the doc lints for my local tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has been made redundant by the
{:#}display specifier since 7577e8c two years ago. It is poorly named, inefficient since it always requires allocating aString, and also broken because it uses debug display for keys.All of our unit tests were converted over to use :# which is why it wasn't noticed that this method didn't work.
Fixes #34
Fixes #85