Pegin desc wildcard #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged #95 -- can rebase and undraft this. |
Since the `Pk` generic on `fed_desc` is the same as in `elem_desc` this binds the kind of user descriptor accepted. `fed_desc` always come in the form with `PublicKey`, thus by removing the generic we can support different `elem_desc`.
Allowing to generate a bunch of pegin addresses from a single pegin descriptor
RCasatta
force-pushed
the
pegin_desc_wildcard
branch
from
bd220a0 to
59362c8
Compare
RCasatta
commented
Dec 2, 2024
| @@ -148,6 +160,7 @@ impl<Pk: MiniscriptKey> Pegin<Pk> { | |||
| { | |||
| // TODO | |||
| Ok(bitcoin::Address::p2shwsh( | |||
| // Should the address type taken from the top level user desc? | |||
There was a problem hiding this comment.
Would this be the right thing to do?
There was a problem hiding this comment.
It should come from the fed_desc field. Probably easiest to match on self.fed_desc.desc_type() (lol we should rename this) and choose the address type based on that. https://docs.rs/miniscript/latest/miniscript/descriptor/enum.Descriptor.html#method.desc_type
There was a problem hiding this comment.
Other than this, 59362c8 looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #95
draft PR to investigate the derivability of a bunch of addresses from a pegin descriptor.
Use the following assumption
bitcoin::PublicKey