hsmd: name the hsmd_ready_channel to hsmd_setup_channel

[vincenzopalazzo]

Originally VLS used hsmd_ready_channel as an early call during channel setup, but later the BOLT-2 spec changed the name of funding_locked to channel_ready.

This is very confusing because the hsmd_ready_channel is not directly related to the new channel_ready.

This commit is renaming the hsmd_ready_channel to hsmd_setup_channel.

Fixes: #6717
Suggested-by: @ksedgwic

[vincenzopalazzo]

Mh this should also notify the vls team alone, but looks like it is not working, I will check it later when the PR is happy. For now adding @ksedgwic manually

[vincenzopalazzo]

A self review before going to bed

[vincenzopalazzo]

Pushed the Ken review, but now there is the CI that it is catch the hsmd change
and tell us to bump a version.

MISSING-HEADERS common
*** hsmd_wire.csv changed to 60b92a0930b631cc77df564cb9235e6cb220f4337a2bb00e5153145e0bf8c80e without update to common/hsm_version.h
make: *** [hsmd/Makefile:63: check-hsm-versions] Error 1
make: *** Waiting for unfinished jobs....

but as @ksedgwic mentioned this is not strictly required. Moving this conversation on Discord
for the people that are interested

---

Streaming here the conversation with @cdecker

The key question here is "does the change break a signer that was working before?" and in this case it seems no. The message format did not change, and we don't really care about the signer using another name for the same concept. There is no semantic change, so a new version should not be needed.

In fact, the hsmd has a versioning check in common/hsm_version.h and this contains multiple changes on the version v4. So I just add a new item with the v4 version

[vincenzopalazzo]

Trivial rebase to fix lnprototest