rs: Bump crates and update bitcoin dependency
#6726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
There are two thinkg in this PR
Unfortunately rust-bitcoin introduce some braking changes like
cp tools/hsmtool tools/lightning-hsmtool
error[E0599]: no method named `to_vec` found for struct `Sha256` in the current scope
--> cln-grpc/src/convert.rs:148:42
|
148 | payment_hash: c.payment_hash.to_vec(), // Rule #2 for type hash
| ^^^^^^ method not found in `Sha256`
error[E0599]: no method named `to_vec` found for struct `Sha256` in the current scope
--> cln-grpc/src/convert.rs:165:48
|
165 | channel_id: c.channel_id.map(|v| v.to_vec()), // Rule #2 for type hash?
| ^^^^^^ method not found in `Sha256`
error[E0599]: no method named `to_vec` found for struct `Sha256` in the current scope
--> cln-grpc/src/convert.rs:274:48
|
274 | channel_id: c.channel_id.map(|v| v.to_vec()), // Rule #2 for type hash?
| ^^^^^^ method not found in `Sha256`
Then lnprototest I started to fails and I am tracking it with #6727
vincenzopalazzo
force-pushed
the
20230926-bump-cln-crates
branch
2 times, most recently
from
0ca2849 to
14917db
Compare
cdecker
force-pushed
the
20230926-bump-cln-crates
branch
from
14917db to
d92ebde
Compare
|
Since I was at it I also added a fix for #6735 |
cdecker
force-pushed
the
20230926-bump-cln-crates
branch
from
59dad0a to
e76650a
Compare
|
cln-rpc and cln-plugin 0.1.6 are already published |
🙏 |
Some methods (`withdraw`) require their parameter to be in satoshis rather than millisats. In order for us not to have to come up with yet another triple of sat, sat_or_all, and sat_or_any, we just bolt it onto the conversion.
cdecker
force-pushed
the
20230926-bump-cln-crates
branch
from
19973b1 to
df40ef5
Compare
cdecker
force-pushed
the
20230926-bump-cln-crates
branch
from
df40ef5 to
fac587b
Compare
Signed-off-by: Peter Neuroth <[email protected]>
|
The Pre-build checks are still complaining about a mismatch in the compiled proto stubs and I don't understand why. CI uses |
Hopefully this will fix the ci. Signed-off-by: Peter Neuroth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fedi project is asking for a new version, and hoping that we switch to
bitcoin==0.30.1to reduce their dependencies. Why not :-)Fixes #6735
Changelog-None